[!!!][FEATURE] Enable basic HTTP caching and use Symfony's reverse proxy #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
added
enhancement
eliashaeussler
force-pushed
the
feature/http-caching
branch
from
4d530d7 to
65bdf9a
Compare
eliashaeussler
force-pushed
the
feature/http-caching
branch
from
65bdf9a to
419e070
Compare
|
Code Climate has analyzed commit 419e070 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.5% (0.0% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## develop #142 +/- ##
=============================================
+ Coverage 99.44% 99.52% +0.08%
- Complexity 75 85 +10
=============================================
Files 17 18 +1
Lines 181 212 +31
=============================================
+ Hits 180 211 +31
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic application cache layer using Symfony's reverse proxy in combination with HTTP caching methods. Since TER API requests are already cached, the cache expiry date can be used and forwarded to the client.
Related: #136