Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Update Progress Indicator #356

Merged
merged 14 commits into from
Jan 9, 2025
Merged

Add Update Progress Indicator #356

merged 14 commits into from
Jan 9, 2025

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Dec 16, 2024 •
edited
Loading

@alainm23 alainm23 marked this pull request as ready for review December 16, 2024 16:32
@alainm23 alainm23 requested a review from a team December 16, 2024 16:47
danirabbit
danirabbit reviewed Dec 16, 2024
View reviewed changes
src/Views/OperatingSystemView.vala Outdated Show resolved Hide resolved
src/Views/OperatingSystemView.vala Outdated Show resolved Hide resolved
src/Views/OperatingSystemView.vala Outdated Show resolved Hide resolved
@stsdc
Copy link
Member

stsdc commented Dec 16, 2024

image
Works for me

@alainm23 alainm23 requested a review from danirabbit December 16, 2024 20:28
@alainm23
Copy link
Contributor Author

I just did my latest tests and it works as expected.

image

@stsdc
Copy link
Member

stsdc commented Dec 18, 2024

For me the whole updates box changes width when the values are being updated. It happens when numbers change. The effect is the jumping width.

ryonakano
ryonakano reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks awesome! I suggested some changes as a PR, would like you to take a look at #360.

ryonakano and others added 3 commits December 28, 2024 11:07
@ryonakano
OperatingSystemView: Suggested changes (#360)
4650004 
- Lessen scope
- Lessen coupling
- Rename the method to avoid confusion of the getter method
- Unify naming notation: "xxx_size_str" is stringfied data of "xxx_size"
@stsdc
Merge branch 'main' into alainm23/update_progress_indicator
5a840c9
@stsdc
Merge branch 'main' into alainm23/update_progress_indicator
2b8eb13
@ryonakano
Copy link
Member

For me the whole updates box changes width when the values are being updated. It happens when numbers change. The effect is the jumping width.

@stsdc Has the above comment been fixed in #359 already?

@stsdc
Copy link
Member

stsdc commented Jan 5, 2025

No, this PR was only for vertical changes.

For horizontal I proposed here in comments.

@alainm23
Copy link
Contributor Author

alainm23 commented Jan 6, 2025

No, this PR was only for vertical changes.

For horizontal I proposed here in comments.

Do you have a screenshot or any way to reproduce the bug?

@stsdc
Copy link
Member

stsdc commented Jan 6, 2025

I have posted screenshots in the review.

@ryonakano
Copy link
Member

@stsdc I couldn't find any screenshots that look like showing the above issue in this PR, I'm sorry but could you post the screenshots again?

@stsdc
Copy link
Member

stsdc commented Jan 8, 2025 •
edited
Loading

Here is the original: #356 (comment)

The issue happens when label updates amount of downloaded bytes, and since numbers are not the same width, the whole container changes width a few pixels.
Here is an exaggerated situation:
obraz

And here I have added wrap property:
obraz

@alainm23 alainm23 requested a review from stsdc January 9, 2025 13:13
@alainm23 alainm23 requested a review from ryonakano January 9, 2025 13:13
@alainm23
Copy link
Contributor Author

alainm23 commented Jan 9, 2025

I just added the wrap property

stsdc
stsdc approved these changes Jan 9, 2025
View reviewed changes
src/Views/OperatingSystemView.vala Outdated Show resolved Hide resolved
@stsdc
Copy link
Member

stsdc commented Jan 9, 2025

LGTM ✅

ryonakano
ryonakano approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me too. I'm also committing to this branch though 🙈

@stsdc stsdc merged commit b0752f7 into main Jan 9, 2025
4 checks passed
@stsdc stsdc deleted the alainm23/update_progress_indicator branch January 9, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsdc stsdc stsdc approved these changes

@ryonakano ryonakano ryonakano approved these changes

@danirabbit danirabbit Awaiting requested review from danirabbit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress indicator when downloading updates
4 participants
@alainm23 @stsdc @ryonakano @danirabbit