Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccentColor Backend #128

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Add AccentColor Backend #128

merged 2 commits into from
Jan 28, 2024

Conversation

Marukesu
Copy link
Contributor

Move the AccentColorManager from gala to settings-daemon, with the following changes:

  • fallback to the primary-color if it fail to get a color from the background.
  • properly listen to changes in the PrefersColorScheme property and don't check for the accent when not required.

alternative to #127.

@Marukesu
Copy link
Contributor Author

Marukesu commented Jan 27, 2024

is there a way to disable vala-lint for a block of lines? making the themes array aligned really helps reading though them.

@Marukesu Marukesu force-pushed the maru/accent-manager branch from cf470ff to 0c2e018 Compare January 27, 2024 18:24
Move the AccentColorManager from gala to settings-daemon, with the following changes:

* fallback to the primary-color if it fail to get a color from the background.
* properly listen to changes in the PrefersColorScheme property and don't check
  for the accent when not required.
@Marukesu Marukesu force-pushed the maru/accent-manager branch from 0c2e018 to d31a708 Compare January 27, 2024 18:49
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is very clean and it works better than ever. Thanks for rewriting this <3

@lenemter lenemter merged commit b2bb693 into master Jan 28, 2024
4 checks passed
@lenemter lenemter deleted the maru/accent-manager branch January 28, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants