Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemUpdate: alter notifications for security updates #121

Merged
merged 12 commits into from
Jan 28, 2024
Merged

SystemUpdate: alter notifications for security updates #121

merged 12 commits into from
Jan 28, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 25, 2024 •
edited
Loading

Fixes #115

@danirabbit danirabbit requested a review from a team January 25, 2024 23:01
@lenemter
Copy link
Member

I don't like that these notifications are urgent. IMO even security updates are not urgent enough to send a loud and flashy notification to ask user to install them.

@danirabbit
Copy link
Member Author

@lenemter bumped it down to HIGH which I think doesn't include the animation, different sound, sticky behavior, etc

lenemter
lenemter approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any security updates to check this. But the code looks good

@danirabbit danirabbit merged commit 350f76c into master Jan 28, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/security-notifications branch January 28, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alter notification when updates are security-related
2 participants
@danirabbit @lenemter