Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay initial check for updates by default 60 seconds #2253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vjr
Copy link
Member

@vjr vjr commented Feb 5, 2025

@vjr vjr self-assigned this Feb 5, 2025
@vjr vjr requested a review from a team February 5, 2025 15:00
@danirabbit
Copy link
Member

AppCenter no longer uses PackageKit so I'm not sure this is still relevant here

@vjr
Copy link
Member Author

vjr commented Feb 5, 2025

AppCenter no longer uses PackageKit so I'm not sure this is still relevant here

The intent is to delay the flatpak check too - does this PR still make sense?

@danirabbit
Copy link
Member

I'm not sure what problem you're trying to solve here with the Flatpak side of things. It seems like you should either turn on automatic updates in appcenter or disallow appcenter from auto starting so you can run Flatpak updates manually in terminal. But I'm generally not a fan of adding magic number timeouts to things

@vjr
Copy link
Member Author

vjr commented Feb 5, 2025

There's already a SECONDS_AFTER_NETWORK_UP constant in here - not intending to add a magic number.

Wanted to (re) solve the (I guess) regression mentioned in elementary/settings-daemon#158 which are the old issues #495 and #721 which is to not hog the system/network as soon as you startup/login.

Let me know if this is sufficient rationale for this PR - otherwise no worries - we can close/drop this one :-)

@danirabbit
Copy link
Member

I think in that case it would be better to do something like check for available resources/user activity instead of using a timeout

@vjr
Copy link
Member Author

vjr commented Feb 5, 2025

I think in that case it would be better to do something like check for available resources/user activity instead of using a timeout

argh! that sound like a mini-project on its own lol. can that be a feature/wishlist item for a later time?

just a reminder this is just bringing back the previously accepted workaround mentioned in this comment but in the code instead of that old config key - im not sure if the old way is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants