-
Notifications
You must be signed in to change notification settings - Fork 411
Just fixed a typo. #19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Just fixed a typo. #19072
Conversation
change completed to complete
|
|
|
|
||
|
|
||
| **Response** | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the PR checklist (was in the PR description template), this needs a changelog entry -> changelog.d/19072.doc
- Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
EventStoretoEventWorkerStore.".- Use markdown where necessary, mostly for
code blocks.- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neuark please create a file at changelog.d/19072.doc that contains a sentence describing what this change does, following the above bullet points.
19072 corresponds to this PR's ID number.
Co-authored-by: Eric Eastwood <[email protected]>
Just fixed a typo .
Fix #18338
Change
completedtocomplete.Contributed by @neuark .