Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): docusaurus 3.6.3 + faster #703

Merged
merged 5 commits into from
Dec 12, 2024
Merged

build(deps): docusaurus 3.6.3 + faster #703

merged 5 commits into from
Dec 12, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Dec 11, 2024

Upgrades to latest Docusaurus and swaps out the underlying build toolchain.

  • Installs @docusaurus/faster, which is an experimental opt-in change that swaps webpack for rspack amongst other tooling changes.
  • Removes esbuild-loader, which we were using to run esbuild bundling via webpack.

Anecdotally, cold builds seem to have gone from 60s long to 30s long on my M1 Max MacBook.

@erickzhao erickzhao requested a review from a team as a code owner December 11, 2024 05:47
Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2024

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: d9058b6
Status: ✅  Deploy successful!
Preview URL: https://82cf83e0.electron-website.pages.dev
Branch Preview URL: https://docusaurus-3-6-3.electron-website.pages.dev

View logs

@erickzhao erickzhao changed the title build(deps): docusaurus 3.6.3 build(deps): docusaurus 3.6.3 + faster Dec 11, 2024
@dsanders11
Copy link
Member

This looks interesting. Can we rebase this on main once #709 is merged? That's the only custom Webpack build step we have AFAIK. I know the Docusaurus blog post says most Webpack plugins should work with rspack, but might as well do that PR first since it ensures this is cleaner.

@erickzhao
Copy link
Member Author

@dsanders11 Done. The other custom part that I removed here was using esbuild-loader instead of whatever the default would be for Docusaurus.

@erickzhao erickzhao merged commit eb24ed9 into main Dec 12, 2024
4 checks passed
@erickzhao erickzhao deleted the docusaurus-3.6.3 branch December 12, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants