Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transform GitHub alert blocks into Docusaurus admonitions #655

Merged
merged 7 commits into from
Nov 13, 2024
Merged

feat: transform GitHub alert blocks into Docusaurus admonitions #655

merged 7 commits into from
Nov 13, 2024

Conversation

AmrMustafa282
Copy link
Contributor

fixed #570

  • added Remark Github Alerts to Directives plugin to docusaurus.config.ts
  • configure the plugin in docs and blog for future need

preview after updates

Screenshot 2024-10-12 at 3 05 23 AM

@AmrMustafa282 AmrMustafa282 requested a review from a team as a code owner October 12, 2024 00:34
@AmrMustafa282 AmrMustafa282 mentioned this pull request Oct 12, 2024
Closed
AmrMustafa282
AmrMustafa282 commented Oct 13, 2024
View reviewed changes
Copy link
Contributor Author

@AmrMustafa282 AmrMustafa282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review

@AmrMustafa282
Copy link
Contributor Author

hey @erickzhao can you review this pull request

@AmrMustafa282 AmrMustafa282 marked this pull request as draft November 8, 2024 09:08
@AmrMustafa282 AmrMustafa282 marked this pull request as ready for review November 8, 2024 09:10
@erickzhao erickzhao changed the title Transform GitHub alert blocks into Docusaurus admonitions feat: transform GitHub alert blocks into Docusaurus admonitions Nov 12, 2024
@erickzhao erickzhao self-requested a review November 12, 2024 23:19
erickzhao
erickzhao reviewed Nov 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
erickzhao
erickzhao approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tweaked a few things and re-landed lockfile changes according to our policies

VerteDinde
VerteDinde approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Erick changed the yarn.lock, so we're good there 😄 )

@erickzhao erickzhao merged commit 7c646d6 into electron:main Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transform GitHub alert blocks into Docusaurus admonitions
3 participants
@AmrMustafa282 @VerteDinde @erickzhao