feat(plugin-vite): support server host in renderer #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
approved these changes
Oct 30, 2025
Comment on lines
+88
to
+89
| const configHost = server.config.server?.host | ||
| const devHost = typeof configHost === 'string' ? configHost : 'localhost' |
There was a problem hiding this comment.
Suggested change
| const configHost = server.config.server?.host | |
| const devHost = typeof configHost === 'string' ? configHost : 'localhost' | |
| const devHost = server.config.server?.host ?? 'localhost' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Electron Forge Vite plugin hardcoded the development server URL to use localhost when exposing the renderer process URL to the main process. This limitation prevented developers from configuring custom host addresses for the Vite development server, which is essential for scenarios such as: