Skip to content

feat(plugin-vite): automatically switch to esm mode when enabled #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −2
Open

feat(plugin-vite): automatically switch to esm mode when enabled #4016

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35082c7
feat: plugin-vite: automatically switch to esm mode when enabled
maximsmol Oct 6, 2025
910e8e9
refactor: fix imports formatting
maximsmol Oct 9, 2025
11adf77
test: fix fixture for vite config
maximsmol Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/plugin/vite/src/config/vite.main.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@
pluginHotRestart,
} from './vite.base.config';

import fs from 'fs-extra';

Check failure on line 10 in packages/plugin/vite/src/config/vite.main.config.ts

View workflow job for this annotation

GitHub Actions / lint-and-build 

`fs-extra` import should occur before import of `vite`

Check failure on line 10 in packages/plugin/vite/src/config/vite.main.config.ts

View workflow job for this annotation

GitHub Actions / lint-and-build 

There should be at least one empty line between import groups
import path from 'node:path';

Check failure on line 11 in packages/plugin/vite/src/config/vite.main.config.ts

View workflow job for this annotation

GitHub Actions / lint-and-build 

`node:path` import should occur before import of `vite`

export function getConfig(
forgeEnv: ConfigEnv<'build'>,
userConfig: UserConfig = {},
): UserConfig {
const { forgeConfigSelf } = forgeEnv;
const { forgeConfigSelf, root } = forgeEnv;
const packageJson = JSON.parse(
fs.readFileSync(path.join(root, 'package.json'), { encoding: 'utf-8' }),
);

const define = getBuildDefine(forgeEnv);
const config: UserConfig = {
build: {
Expand All @@ -34,7 +41,7 @@
config.build!.lib = {
entry: forgeConfigSelf.entry,
fileName: () => '[name].js',
formats: ['cjs'],
formats: packageJson.type !== 'module' ? ['cjs'] : ['es'],
};
}

Expand Down
Loading