build(deps): TypeScript 5.4 #3790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -294,7 +292,7 @@ export const listrMake = ( | |||
| arch: targetArch, | |||
| }); | |||
| } catch (err) { | |||
| if (err) { | |||
There was a problem hiding this comment.
This is semantically different, in some places we throw strings, we should still somehow log those?
There was a problem hiding this comment.
Are there specific places where we throw strings? This was caught in lint by "@typescript-eslint/only-throw-error".
There was a problem hiding this comment.
I've definitely done it before, probably in forge, or it's dependencies 😅
There was a problem hiding this comment.
Not sure if we still do it today or not
There was a problem hiding this comment.
Added another else if clause for when the error is a string as well: 12efc76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our version of TypeScript is a few years out of date. DefinitelyTyped only supports versions that are 2 years old.
This PR upgrades us from TypeScript 4 to TypeScript 5.4, which is the latest version supported by our current version of TypeDoc.
The actual source code change here is fairly small, but upgrading to TypeScript 5 required us to upgrade our linting stack, which caused the diff to balloon:
@typescript-eslint/no-var-requires->@typescript-eslint/no-require-imports).eslint-plugin-importseems to have changed.Note that we require a yarn resolution to
@typescript-eslint/parserbecause@malept/eslint-confighas a direct dependency on@typescript-eslint/parser@5, which limits us to TypeScript 4.6.