Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Electron 33.3.0 #1662

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: update to Electron 33.3.0 #1662

merged 1 commit into from
Dec 11, 2024

Conversation

dsanders11
Copy link
Member

Required fixing the types in a test, I believe due to the change upstream in electron/typescript-definitions#273. Since app.on is overloaded, TypeScript ends up choosing the last signature, which used to be Function before that change (fully permissive when invoking), after which it became () => void. Unfortunately it appears there's no way to extract the callback signature of just the events we want, so I manually rolled the types to get this building cleanly again.

When inferring from a type with multiple call signatures (such as the type of an overloaded function), inferences are made from the last signature (which, presumably, is the most permissive catch-all case). It is not possible to perform overload resolution based on a list of argument types.

@coveralls
Copy link

Coverage Status

coverage: 87.597%. remained the same
when pulling 2845388 on chore/bump-electron-33
into 4d7f807 on main.

@dsanders11 dsanders11 marked this pull request as ready for review December 11, 2024 22:49
@dsanders11 dsanders11 requested review from codebytere and a team as code owners December 11, 2024 22:49
@dsanders11 dsanders11 merged commit f0e0157 into main Dec 11, 2024
10 checks passed
@dsanders11 dsanders11 deleted the chore/bump-electron-33 branch December 11, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants