Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required fixing the types in a test, I believe due to the change upstream in electron/typescript-definitions#273. Since
app.on
is overloaded, TypeScript ends up choosing the last signature, which used to beFunction
before that change (fully permissive when invoking), after which it became() => void
. Unfortunately it appears there's no way to extract the callback signature of just the events we want, so I manually rolled the types to get this building cleanly again.