Dont create dev cert if certificate is not explicitly specified #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the work you're doing.
In my project, we use the https://github.com/electron/windows-sign
automaticallySelectCertificateoption and leave the administration of the certificate to the owner of the ci runner.Unfortunately, unless I missed something, in
msixmaker, if I don't explicitly specify a certificate file, it triggers the creation of a dev certificate which kind of makes sense but blocks me.I would like to suggest to add a way with configuration to be able to not have a
certificateFilewhile not using the dev cert.This PR suggest a simple way, instead of activating the dev cert only with
certificateFileprop being set, deactivate dev cert if anywindowsSignOptionsare set. At least it works for me (I plugged my fork for now). What do you think?