Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django registration redux for 1password passage #199

Conversation

fsargent
Copy link
Contributor

@fsargent fsargent commented Feb 2, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request updates the project's CI/CD pipeline, Docker configuration, and Django settings to reflect changes in the deployment environment, such as moving from the 'master' to 'main' branch, upgrading Python to version 3.11, and adjusting static file storage settings. It also introduces an entrypoint script for the Docker container to handle migrations and static files collection.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that all dependencies are compatible with Python 3.11 to avoid potential runtime issues.
  • Consider the implications of setting 'DEBUG: False' in the 'docker-compose.yml' for local development environments and manage this setting through environment variables for different deployment scenarios.
  • Review the change in static files storage settings to ensure it aligns with the caching and serving strategy for static assets.
  • Assess whether running 'collectstatic' at container startup is the best approach, as it can slow down deployments, and consider handling static files collection during the image build process.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@fsargent fsargent closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant