Open
Conversation
…ent container Adds additional state-hidden class for hidden content elements
Owner
|
Thanks for your PR @LOK-Soft, apparently LGTM. Could you add a test for this new feature? If not, don't worry, I'll do it when I've time, just tell it to me. |
LOK-Soft
force-pushed
the
feature/tabContentSelector
branch
from
13f10f2 to
fa362e1
Compare
Author
|
added basic test, is this test sufficent? |
Owner
|
Sorry didn't see it before! I think it's enough 😄 |
Owner
|
Ignore the travis build failing.. I think it's related to something I did some days ago. I'll check it when possible and accept the PR. Again, thanks for your contribution @LOK-Soft 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to set selector for tab content