Skip to content

Conversation

@raviranjanelastisys
Copy link
Contributor

@raviranjanelastisys raviranjanelastisys commented Mar 19, 2024

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

@raviranjanelastisys raviranjanelastisys changed the title adr-0048|: subscription-per-customer-model-on-azure adr-0048: subscription-per-customer-model-on-azure Mar 19, 2024
Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently in talks with Azure representatives regarding how we should position ourselves in their marketplace and are going to have a discussion with their technical advisors in the, hopefully, coming days. Therefore I'd postpone sealing this decision in an ADR before we've heard their suggestions while not blocking beta. Is that possible?

@simonklb
Copy link
Contributor

I would also like to see multiple tenants as an evaluated option. Maybe it's obvious why it would not be an viable option but let's put it in writing. Take Azure lighthouse into consideration when evaluating multi-tenancy.

@raviranjanelastisys
Copy link
Contributor Author

efore we've heard their suggestions while not blocking bet

Sure !! I will keep this ADR on hold until we hear from Azure team too !! Yeah for now, it shouldn't be Beta blocker from our end.

Chosen option:

- Isolation at the Subscription level i.e Subscription-per-Customer Model.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about environments of the same customer? How will those be isolated? Separate subscription or resource groups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say separate subscriptions. So we can treat subscriptions as projects in openstack and then we have some similarity with them.

@raviranjanelastisys raviranjanelastisys force-pushed the rranjan/subscription-azure branch from 1091a74 to de82ef3 Compare March 25, 2024 14:21
@raviranjanelastisys raviranjanelastisys changed the title adr-0048: subscription-per-customer-model-on-azure adr-0048 subscription-per-customer-model-on-azure Sep 17, 2024
@cristiklein
Copy link
Collaborator

@raviranjanelastisys Just noticed this PR. Can you give it another push?

@raviranjanelastisys
Copy link
Contributor Author

@raviranjanelastisys Just noticed this PR. Can you give it another push?

Yeah We now have good understanding, I will give another push :) , thanks for reminding me.

@raviranjanelastisys
Copy link
Contributor Author

@cristiklein If the traditional on-boarding method is deprecated, this ADR may no longer be necessary since customers now have the flexibility to choose via Marketplace whether to deploy Welkin in a dedicated or new subscription within their own tenant, without impacting our Welkin offerings.

@raviranjanelastisys
Copy link
Contributor Author

I got an update from Commercial recently it is still relevant because there might be some reason customer don't have anything running on Azure and don't have expertise. In such scenarios, We can offer the Welkin on our tenant.

@vomba Hi Hani, do you think you can spend some time here if interested in this ADR ? Otherwise, I will have a look.

@lucianvlad
Copy link
Contributor

@vomba can you please fix the conflicts and check if anything is missing or has changed in the meantime?
Thank you !

@vomba vomba changed the title adr-0048 subscription-per-customer-model-on-azure adr-0060 subscription-per-customer-model-on-azure Nov 7, 2025
@vomba vomba force-pushed the rranjan/subscription-azure branch from de82ef3 to c95e1b4 Compare November 7, 2025 09:14
@vomba
Copy link
Contributor

vomba commented Nov 7, 2025

I think everything is good here, unless someone has any other comment.

@cristiklein cristiklein force-pushed the rranjan/subscription-azure branch from c95e1b4 to c20e9b9 Compare November 7, 2025 09:32
Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vomba for double-checking the content. I made pre-commit happy and regenerated the index.

@lucianvlad Can you double-check and merge if happy. Thanks!

@vomba vomba changed the title adr-0060 subscription-per-customer-model-on-azure adr-0061 subscription-per-customer-model-on-azure Nov 7, 2025
@cristiklein
Copy link
Collaborator

@simonklb Any more comments from your end or is this ready to merge?

Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me but it would be good for someone in @elastisys/goto-azure and/or OPS to sign off and make sure this is actually how we run things now.

@cristiklein
Copy link
Collaborator

Thanks @simonklb . @vomba is part of @elastisys/goto-azure , so ... I gather we have it signed off by GOTO Azure. 😄

@davidumea Any concerns you see before officially merging this ADR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants