Remove duplication in installation scripts #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having mostly duplicate scripts for the entire installation process, we can split them up into the base installation steps and then run shell provisioners for anything specific to each of the types after the machine has rebooted.
This structure will mean less chance of error when making changes to machines, and will also allow for expansion of the scripts to be run at the end, such as adding a minimization script to remove history and clear out space on the drive before compression.
@rezonanc would you be able to confirm that Parallels builds still work with this reorganization? Using the script provisioner should ensure that there is not kernel version mismatch like you were worried about with your original PR.
Related to progress on #41