Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide full paths when verifying contents of keystore #2870

Closed
wants to merge 19 commits into from

Conversation

auslaner
Copy link

Updates check of keystore with sudo and full paths to the keytool and the keystore file.

This change seems to make things more consistent with the previous commands. Also if you try this command without sudo included, the user may get the error Keystore file does not exist which is confusing. The previous command includes sudo so it makes sense to include it here as well.

mergify bot and others added 13 commits September 11, 2024 21:47
(cherry picked from commit b6cb7ca)

Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 068e461)

Co-authored-by: István Zoltán Szabó <[email protected]>
…docs. (elastic#2828) (elastic#2829)

(cherry picked from commit 04632d2)

Co-authored-by: István Zoltán Szabó <[email protected]>
)

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Dima Arnautov <[email protected]>
Co-authored-by: István Zoltán Szabó <[email protected]>
* [DOCS] Changes trained model UI screenshot.

* [DOCS] Further edits.

(cherry picked from commit b2f576c)

Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit a52fc2a)

Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit 4e34d07)

Co-authored-by: István Zoltán Szabó <[email protected]>
* Improves trained model autoscaling docs.

* Fixes typo in autoscaling docs.

(cherry picked from commit 6f34f30)

Co-authored-by: István Zoltán Szabó <[email protected]>
Updates check of keystore with sudo and full paths to the keytool and the keystore file.
@auslaner auslaner requested a review from a team as a code owner November 16, 2024 21:27
Copy link

cla-checker-service bot commented Nov 16, 2024

💚 CLA has been signed

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@auslaner
Copy link
Author

run docs-build

(cherry picked from commit dd4cc37)

Co-authored-by: kosabogi <[email protected]>
@shainaraskas
Copy link
Contributor

run docs-build

@shainaraskas
Copy link
Contributor

hey @auslaner - I just realized that you made this change against 8.16. the change should be made against main and then backported instead.

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned above

@auslaner auslaner changed the base branch from 8.16 to main November 21, 2024 17:07
@auslaner auslaner requested a review from a team as a code owner November 21, 2024 17:07
Copy link
Contributor

mergify bot commented Nov 21, 2024

This pull request is now in conflict. Could you fix it @auslaner? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch <remote-repo>
git checkout -b patch-1 <remote-repo>/patch-1
git merge <remote-repo>/main
git push <remote-repo> patch-1

Copy link
Contributor

mergify bot commented Nov 21, 2024

This pull request does not have a backport label. Could you fix it @auslaner? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Nov 21, 2024
@szabosteve szabosteve removed the backport-skip Skip automated backport with mergify label Jan 29, 2025
@szabosteve szabosteve added backport-8.17 Automated backport with mergify backport-8.x Automated backport with mergify v8.17 v8.18 v9.0 labels Jan 29, 2025
@szabosteve
Copy link
Contributor

@elasticmachine update branch

szabosteve
szabosteve previously approved these changes Jan 29, 2025
@szabosteve
Copy link
Contributor

szabosteve commented Jan 29, 2025

@shainaraskas This targets main now. Can you approve it if you also find it okay? Merging is blocked until you don't give it a thumbs-up. Thank you!

@shainaraskas shainaraskas enabled auto-merge (squash) January 29, 2025 18:48
@shainaraskas
Copy link
Contributor

run docs-build

@shainaraskas
Copy link
Contributor

I've had to replace this with #2938 to make sure it got merged. Thank you for your contribution!

auto-merge was automatically disabled January 29, 2025 20:31

Pull request was closed

shainaraskas added a commit that referenced this pull request Jan 29, 2025
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
shainaraskas added a commit that referenced this pull request Jan 29, 2025
…2939)

replaces #2870

(cherry picked from commit 7913b1c)

Co-authored-by: shainaraskas <[email protected]>
shainaraskas added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport with mergify backport-8.17 Automated backport with mergify v8.17 v8.18 v9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants