Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on-prem stack install demo #2597

Merged
merged 35 commits into from
Jan 12, 2024
Merged

Add on-prem stack install demo #2597

merged 35 commits into from
Jan 12, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Nov 21, 2023 •
edited
Loading

@kilfoyle kilfoyle added the backport-skip Skip automated backport with mergify label Nov 21, 2023
@kilfoyle kilfoyle requested a review from a team as a code owner November 21, 2023 21:22
@kilfoyle kilfoyle marked this pull request as draft November 21, 2023 21:22
@elastic elastic deleted a comment from github-actions bot Nov 23, 2023
@kilfoyle kilfoyle marked this pull request as ready for review January 10, 2024 21:41
@kilfoyle
Copy link
Contributor Author

Thanks for the super careful review @eric-cobb! All of your comments are addressed now.

eric-cobb
eric-cobb approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@eric-cobb eric-cobb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work; really, really well-written! I appreciate the countless hours you put into this. It will help our customers tremendously. Enjoyed working with you on this!

karenzone
karenzone approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kilfoyle kilfoyle merged commit da51380 into elastic:main Jan 12, 2024
4 checks passed
@kilfoyle kilfoyle added backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify and removed backport-skip Skip automated backport with mergify labels Jan 12, 2024
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
@kilfoyle @mergify
Add on-prem stack install demo (#2597)
95c4fa0 
* Add on-prem stack install demo

* Add steps 3 & 4

* Add Kibana install steps

* Add steps for Fleet Server

* Add agent & view data steps

* I can't count, apparently.

* fixup

* fixup

* Fix agent and kibana steps, including port 8220 fixes

* Add certificates section

* typo

* Split security steps into a 'part 2'  guide

* Cleanup

* Improve note about jumping to second guide

* Fix start and stop; fix chown

* Add Kibana SSL steps

* Fleet steps

* Finish Fleet & Agent steps

* Fix intro

* Cleanup

* Add overview diagram

* Add conclusion

* Add warning not to start the service yet

* re-enable test flags

* Address Eric's comments

* Fixup

* Fixup

* fixup

* Fixup

* Fixup

* fixup

* fixup

* Fixup; and unset version variables

* Latest review comments

* Use full URLs for package list

(cherry picked from commit da51380)
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
@kilfoyle @mergify
Add on-prem stack install demo (#2597)
c6c6815 
* Add on-prem stack install demo

* Add steps 3 & 4

* Add Kibana install steps

* Add steps for Fleet Server

* Add agent & view data steps

* I can't count, apparently.

* fixup

* fixup

* Fix agent and kibana steps, including port 8220 fixes

* Add certificates section

* typo

* Split security steps into a 'part 2'  guide

* Cleanup

* Improve note about jumping to second guide

* Fix start and stop; fix chown

* Add Kibana SSL steps

* Fleet steps

* Finish Fleet & Agent steps

* Fix intro

* Cleanup

* Add overview diagram

* Add conclusion

* Add warning not to start the service yet

* re-enable test flags

* Address Eric's comments

* Fixup

* Fixup

* fixup

* Fixup

* Fixup

* fixup

* fixup

* Fixup; and unset version variables

* Latest review comments

* Use full URLs for package list

(cherry picked from commit da51380)
This was referenced Jan 12, 2024
Merged
Merged
@kilfoyle kilfoyle mentioned this pull request Jan 12, 2024
Closed
kilfoyle added a commit to kilfoyle/stack-docs that referenced this pull request Jan 12, 2024
@kilfoyle
Add on-prem stack install demo (elastic#2597)
0eb6651 
* Add on-prem stack install demo

* Add steps 3 & 4

* Add Kibana install steps

* Add steps for Fleet Server

* Add agent & view data steps

* I can't count, apparently.

* fixup

* fixup

* Fix agent and kibana steps, including port 8220 fixes

* Add certificates section

* typo

* Split security steps into a 'part 2'  guide

* Cleanup

* Improve note about jumping to second guide

* Fix start and stop; fix chown

* Add Kibana SSL steps

* Fleet steps

* Finish Fleet & Agent steps

* Fix intro

* Cleanup

* Add overview diagram

* Add conclusion

* Add warning not to start the service yet

* re-enable test flags

* Address Eric's comments

* Fixup

* Fixup

* fixup

* Fixup

* Fixup

* fixup

* fixup

* Fixup; and unset version variables

* Latest review comments

* Use full URLs for package list

(cherry picked from commit da51380)
@kilfoyle
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
✅ 8.12
❌ 8.11 The branch "8.11" is invalid or doesn't exist

Manual backport

To create the backport manually run:

backport --pr 2597

Questions ?

Please refer to the Backport tool documentation

kilfoyle added a commit that referenced this pull request Jan 12, 2024
@mergify @kilfoyle
Add on-prem stack install demo (#2597) (#2637)
1f99365 
* Add on-prem stack install demo

* Add steps 3 & 4

* Add Kibana install steps

* Add steps for Fleet Server

* Add agent & view data steps

* I can't count, apparently.

* fixup

* fixup

* Fix agent and kibana steps, including port 8220 fixes

* Add certificates section

* typo

* Split security steps into a 'part 2'  guide

* Cleanup

* Improve note about jumping to second guide

* Fix start and stop; fix chown

* Add Kibana SSL steps

* Fleet steps

* Finish Fleet & Agent steps

* Fix intro

* Cleanup

* Add overview diagram

* Add conclusion

* Add warning not to start the service yet

* re-enable test flags

* Address Eric's comments

* Fixup

* Fixup

* fixup

* Fixup

* Fixup

* fixup

* fixup

* Fixup; and unset version variables

* Latest review comments

* Use full URLs for package list

(cherry picked from commit da51380)

Co-authored-by: David Kilfoyle <[email protected]>
kilfoyle added a commit that referenced this pull request Jan 12, 2024
@mergify @kilfoyle
Add on-prem stack install demo (#2597) (#2636)
5515019 
* Add on-prem stack install demo

* Add steps 3 & 4

* Add Kibana install steps

* Add steps for Fleet Server

* Add agent & view data steps

* I can't count, apparently.

* fixup

* fixup

* Fix agent and kibana steps, including port 8220 fixes

* Add certificates section

* typo

* Split security steps into a 'part 2'  guide

* Cleanup

* Improve note about jumping to second guide

* Fix start and stop; fix chown

* Add Kibana SSL steps

* Fleet steps

* Finish Fleet & Agent steps

* Fix intro

* Cleanup

* Add overview diagram

* Add conclusion

* Add warning not to start the service yet

* re-enable test flags

* Address Eric's comments

* Fixup

* Fixup

* fixup

* Fixup

* Fixup

* fixup

* fixup

* Fixup; and unset version variables

* Latest review comments

* Use full URLs for package list

(cherry picked from commit da51380)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-cobb eric-cobb eric-cobb approved these changes

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilfoyle @karenzone @eric-cobb