-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Next.js 12, EUI 41.3 #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again Rory! Changes LGTM, tested with both dev & prod modes.
I pushed a complete regeneration of yarn.lock to opt into some additional updates & clean up duplicated packages.
This comes from EuiSideNav and is an unconfigurable thing, https://github.com/elastic/eui/blob/main/src/components/side_nav/side_nav.tsx#L188 Thankfully, apart from this warning, nothing breaks (unless you're on a really old react@15 version) and React updates the |
This PR updates all dependencies
apart from EUI. Notably, that means an upgrade of Next.js from v11 to v12. There were surprisingly few changes to make this work. ESLint had to be kept back because Next.js complained about using the latest version. I expect that to be relaxed in the future.Future PRs:
Upgrade EUIActually, upgrading EUI turned out to be trivial so I've included it.