[8.x] [ES|QL] Separate EVAL autocomplete routine (#212996)
#214968
Merged
+750
−1,100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Part of elastic#195418 Gives `EVAL` autocomplete logic its own home 🏡 ### Expression suggestions function This PR also introduces a semi-generic function for generating suggestions within an expression. This is so that the logic can be shared between `EVAL` and `WHERE`. It also gets us closer to supporting filtering in `STATS` (elastic#195363). To make this happen, I took stock of where we have differences in our expression suggestions between `WHERE` and `EVAL`. In some cases, the differences seemed important. In other cases, I felt ok removing them. #### EVAL | Behavior | Plan | |--------------------------------------------------------------------------|------| | Suggests pipe and comma after complete column names (`column/` or `column /`)| get rid of it because an expression consisting of just a single column name is essentially useless in `EVAL` | | Doesn't suggest fields after an assignment | get rid of it. why act any different than an expression not assigned an alias? | | Suggests assignment operator after new column name (`newColumn /`) | keep it | | Suggests assignment snippet for empty expression | keep it | | Suggests time literal completions after literal number in assignment (`newColumn = 1 /`) | remove it. it doesn't feel that useful and removing it makes it easier to have a generic expression suggestions function. It will still be around in functions and operators (e.g. `1 day + 2 /`). | | Supports multiple expressions | keep it | #### WHERE | Behavior | Plan | |--------------------------------------------------------------------------|------| | Suggests pipe after complete boolean expression (`foo AND bar /`) | keep it, but outside of the expression suggestion function | | Suggests boolean operators to make a boolean expression (`timestamp > "2002" AND doubleField /`) | keep it... maybe we're being too smart but we can always remove it later | ### Other changes - the suggestions for `CASE(foo != /)` used to differ based on the trigger kind. This seemed inadvertent so I removed the difference. - we now add spaces after fields that are inserted in expressions. E.g. `WHERE foo + <insert field><space>`. I'm not sure if this is best or not... ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Identify risks - [ ] As with any refactor, there's a possibility this will introduce a regression in the behavior of commands. However, all automated tests are passing and I have tested the behavior manually and can detect no regression. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 74c31fb)
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
Unreferenced deprecated APIs
cc @drewdaemon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:EVALautocomplete routine (#212996)Questions ?
Please refer to the Backport tool documentation