[8.17] Remove inference_id field if no inference endpoint is selected (#205660) #209351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic#205660) ## Summary Currently, the `semantic_text` field supports a default `inference_id`, meaning users are not required to explicitly select an inference endpoint during mapping. However, a bug has been identified: if the `Select inference Id` popover is not opened, the `inference_id` field property remains as an empty string. This causes Elasticsearch (ES) to throw an error, as it requires a value to be present if the property is defined. To address this issue, the proposed solution is to remove the `inference_id` property from the `semantic_text` field during field mapping if its value is empty. ### Screen Recording https://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44 --------- Co-authored-by: Matthew Kime <[email protected]> (cherry picked from commit c8e0408)
TattdCodeMonkey
approved these changes
Feb 3, 2025
sphilipse
approved these changes
Feb 3, 2025
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation
\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Samiul Monir <[email protected]>"}},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->