[9.0] [Dataset Quality] Fix flaky tests discover navigation (#208909) #209244
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Closes elastic#206734 - The PR adds a retry logic while getting the Datasource Selector text on the Discover page. - Also renames the tests as they were missed when migration of links from Log Explorer to Discover were done ### Why do we need retry logic We navigate using locators. **Without retry** - The link generated has a hash and thus the check for `dataSelectorId` fails ``` https://achyut-mki-test-runner-e64297.kb.eu-west-1.aws.qa.elastic.cloud/app/r?l=DISCOVER_APP_LOCATOR&v=9.0.0&lz=N4IgLglgtgpgSgQwHYHMYgFygGYCcD2UmIS%2BA7gLQBMALABYgA04%2BxpZIAvs7jHjAGc6ASSRgYuAG4IANplAAHBAFcB6DGFzKYzaTO2YAbAAZTx7iAAmCMAgBqEGGWGXiM%2FCgEUESgMZ0YADoEX19BLwAqJisbe0cyAGUFGF95EAhXDBB3T28%2FAODQ8Ioo5kgwGXVsjy8fEIKQsIFI6MhYADFHGUsAOQRYYgABNsFbKAUuZgBHbVwATzSZZBRlBDRiAGtZhent4gB9CBRSXksMAAIoi198fSgkAUwAbQBdZmwIGXFcR4wn0FgtjSECQlhgAA83DU8vUgo1ilddhIFlgQFAbP59go6LgEGo0tZbPsBJoYP1Akh%2BoI%2FFUFARLMpfJB8EguJxOG90mIJHpiCowKxmAJ8LgwM8niBhtBRv0JswwQJUi8XpwgA%3D%3D%3D ``` **With retry** - This link then redirects to as Discover Locator resolves it to ``` https://achyut-mki-test-runner-e64297.kb.eu-west-1.aws.qa.elastic.cloud/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-24h,to:now))&_a=(columns:!(),dataSource:(dataViewId:%27logs-apache.access-*%27,type:dataView),filters:!((meta:(index:%27logs-apache.access-*%27),query:(match_phrase:(data_stream.namespace:production)))),interval:auto,query:(language:kuery,query:%27_ignored:%20*%27),sort:!(!(%27@timestamp%27,desc))) ``` **Tested on MKI before and after the fix to confirm the issue is evidently reproducible and with the fix goes away** (cherry picked from commit 91ce0ba)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation