Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] [Playground] Hide create index button when plugin not available #209165

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

yansavitski
Copy link
Contributor

@yansavitski yansavitski commented Jan 31, 2025

Summary

Hide create index button when elastisearch feature is disabled

@yansavitski yansavitski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Jan 31, 2025
@yansavitski yansavitski marked this pull request as ready for review January 31, 2025 19:33
@yansavitski yansavitski requested a review from a team as a code owner January 31, 2025 19:33
@TattdCodeMonkey TattdCodeMonkey added backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting labels Jan 31, 2025
@yansavitski yansavitski added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels and removed backport:version Backport to applied version labels backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 31, 2025
@yansavitski yansavitski enabled auto-merge (squash) January 31, 2025 19:39
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / CreateIndexButton renders correctly when there is a locator
  • [job] [logs] Jest Tests #10 / CreateIndexButton renders correctly when there is a locator
  • [job] [logs] Jest Tests #10 / CreateIndexButton renders correctly when there is no locator
  • [job] [logs] Jest Tests #10 / CreateIndexButton renders correctly when there is no locator

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchPlayground 285 286 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchPlayground 199.5KB 199.4KB -50.0B

History

@yansavitski yansavitski merged commit 78606e0 into elastic:main Feb 3, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13115467939

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ble (elastic#209165)

## Summary

Hide create index button when elastisearch feature is disabled

(cherry picked from commit 78606e0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 3, 2025
…available (#209165) (#209313)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Search] [Playground] Hide create index button when plugin not
available (#209165)](#209165)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yan
Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-03T14:15:42Z","message":"[Search]
[Playground] Hide create index button when plugin not available
(#209165)\n\n## Summary\n\nHide create index button when elastisearch
feature is
disabled","sha":"78606e0fcff3594108830a9bbbdf0497d7dc4d4b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v9.1.0"],"title":"[Search]
[Playground] Hide create index button when plugin not
available","number":209165,"url":"https://github.com/elastic/kibana/pull/209165","mergeCommit":{"message":"[Search]
[Playground] Hide create index button when plugin not available
(#209165)\n\n## Summary\n\nHide create index button when elastisearch
feature is
disabled","sha":"78606e0fcff3594108830a9bbbdf0497d7dc4d4b"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209165","number":209165,"mergeCommit":{"message":"[Search]
[Playground] Hide create index button when plugin not available
(#209165)\n\n## Summary\n\nHide create index button when elastisearch
feature is
disabled","sha":"78606e0fcff3594108830a9bbbdf0497d7dc4d4b"}}]}]
BACKPORT-->

Co-authored-by: Yan Savitski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants