[Obs AI Assistant] Fix multiple flyouts #209158
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduni94
added
release_note:fix
v9.0.0
Team:Obs AI Assistant
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
neptunian
approved these changes
Jan 31, 2025
|
Starting backport for target branches: 8.16, 8.17, 8.18, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
(cherry picked from commit 50b8776)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
(cherry picked from commit 50b8776)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
(cherry picked from commit 50b8776)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
(cherry picked from commit 50b8776)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 31, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[Obs AI Assistant] Fix multiple flyouts (#209158)](#209158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T19:59:01Z","message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0","v8.16.4","v8.17.2","v9.1.0"],"title":"[Obs AI Assistant] Fix multiple flyouts","number":209158,"url":"https://github.com/elastic/kibana/pull/209158","mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209158","number":209158,"mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 31, 2025
# Backport This will backport the following commits from `main` to `8.16`: - [[Obs AI Assistant] Fix multiple flyouts (#209158)](#209158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T19:59:01Z","message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0","v8.16.4","v8.17.2","v9.1.0"],"title":"[Obs AI Assistant] Fix multiple flyouts","number":209158,"url":"https://github.com/elastic/kibana/pull/209158","mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209158","number":209158,"mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 31, 2025
# Backport This will backport the following commits from `main` to `8.17`: - [[Obs AI Assistant] Fix multiple flyouts (#209158)](#209158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T19:59:01Z","message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0","v8.16.4","v8.17.2","v9.1.0"],"title":"[Obs AI Assistant] Fix multiple flyouts","number":209158,"url":"https://github.com/elastic/kibana/pull/209158","mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209158","number":209158,"mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 1, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Obs AI Assistant] Fix multiple flyouts (#209158)](#209158) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T19:59:01Z","message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0","v8.16.4","v8.17.2","v9.1.0"],"title":"[Obs AI Assistant] Fix multiple flyouts","number":209158,"url":"https://github.com/elastic/kibana/pull/209158","mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209158","number":209158,"mergeCommit":{"message":"[Obs AI Assistant] Fix multiple flyouts (#209158)","sha":"50b8776b1fb6e7e6e2a96a8b61edc499579bf260"}}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204087
Summary
Problem
The Nav Control component re-renders multiple times in certain workflows. But this is not unmounted correctly, allowing multiple subscriptions.
Solution
Unmount the component correctly so that
conversationSubscription.unsubscribe();is called.Checklist
release_note:*label is applied per the guidelines