Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Delete confirmation modal content fix #208184

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented Jan 24, 2025

Summary

This PR fixes the issue described here where the input label was misleading when a connector doesn't have a name. Now this label is rendered only when it has a name, otherwise the label is not rendered.

CleanShot.2025-01-24.at.13.11.11.mp4

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner January 24, 2025 12:14
@JoseLuisGJ JoseLuisGJ changed the title Conditional rendering label based on connectorName value [Search] Delete confirmation modal content fix Jan 24, 2025
@JoseLuisGJ JoseLuisGJ self-assigned this Jan 24, 2025
@JoseLuisGJ JoseLuisGJ added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Jan 24, 2025
@@ -46,6 +46,7 @@ export const ElasticManagedConnectorsEmptyPrompt: React.FC = () => {
}
)}
isComingSoon
comingSoonLabel={COMING_SOON_LABEL}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix was not related to the original issue but I spotted we were not rendering nor passing properly the Coming soon text here

@JoseLuisGJ
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
serverlessSearch 357.5KB 357.5KB +29.0B

History

cc @JoseLuisGJ

@JoseLuisGJ JoseLuisGJ merged commit 000d682 into elastic:main Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants