Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inference] add support for auto function calling mode #208144

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jan 24, 2025

Summary

Fix #208143

Add a new value for the functionCalling parameter, auto, which is the new default.

When functionCalling=auto, the system will detect if the underlying model/provider supports native function calling, and otherwise automatically fallback to simulated function calling.

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.18.0 backport:version Backport to applied version labels labels Jan 24, 2025
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet changed the title [inference] add support for auto native function calling mode [inference] add support for auto function calling mode Jan 24, 2025
@pgayvallet
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 24, 2025

💔 Build Failed

Failed CI Steps

History

@pgayvallet pgayvallet force-pushed the kbn-208143-inference-auto-FC branch from f5f12ad to 35daba3 Compare January 24, 2025 08:46
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review January 24, 2025 10:40
@pgayvallet pgayvallet requested review from a team as code owners January 24, 2025 10:40
@pgayvallet pgayvallet merged commit c22b982 into elastic:main Jan 24, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12949974943

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 24, 2025
)

## Summary

Fix elastic#208143

Add a new value for the `functionCalling` parameter, `auto`, which is
the new default.

When `functionCalling=auto`, the system will detect if the underlying
model/provider supports native function calling, and otherwise
automatically fallback to simulated function calling.

(cherry picked from commit c22b982)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 24, 2025
…ode (#208144) (#208193)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[inference] add support for `auto` function calling mode
(#208144)](#208144)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-24T12:50:19Z","message":"[inference]
add support for `auto` function calling mode (#208144)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/208143\r\n\r\nAdd a new value
for the `functionCalling` parameter, `auto`, which is\r\nthe new
default.\r\n\r\nWhen `functionCalling=auto`, the system will detect if
the underlying\r\nmodel/provider supports native function calling, and
otherwise\r\nautomatically fallback to simulated function
calling.","sha":"c22b9828a6551ea5205a025f1c5ace4046bdc66c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"[inference]
add support for `auto` function calling
mode","number":208144,"url":"https://github.com/elastic/kibana/pull/208144","mergeCommit":{"message":"[inference]
add support for `auto` function calling mode (#208144)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/208143\r\n\r\nAdd a new value
for the `functionCalling` parameter, `auto`, which is\r\nthe new
default.\r\n\r\nWhen `functionCalling=auto`, the system will detect if
the underlying\r\nmodel/provider supports native function calling, and
otherwise\r\nautomatically fallback to simulated function
calling.","sha":"c22b9828a6551ea5205a025f1c5ace4046bdc66c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208144","number":208144,"mergeCommit":{"message":"[inference]
add support for `auto` function calling mode (#208144)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/208143\r\n\r\nAdd a new value
for the `functionCalling` parameter, `auto`, which is\r\nthe new
default.\r\n\r\nWhen `functionCalling=auto`, the system will detect if
the underlying\r\nmodel/provider supports native function calling, and
otherwise\r\nautomatically fallback to simulated function
calling.","sha":"c22b9828a6551ea5205a025f1c5ace4046bdc66c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <[email protected]>
pgayvallet added a commit that referenced this pull request Jan 27, 2025
… APIs (#208198)

## Summary

Follow-up of #208144

The inference APIs can now detect if the underlying model / connector
supports native function calling using the `functionCalling: "auto"`
parameter. This PR adapts the calls done from the security assistant to
use that new value

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2025
… APIs (elastic#208198)

## Summary

Follow-up of elastic#208144

The inference APIs can now detect if the underlying model / connector
supports native function calling using the `functionCalling: "auto"`
parameter. This PR adapts the calls done from the security assistant to
use that new value

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dc54c11)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
)

## Summary

Fix elastic#208143

Add a new value for the `functionCalling` parameter, `auto`, which is
the new default.

When `functionCalling=auto`, the system will detect if the underlying
model/provider supports native function calling, and otherwise
automatically fallback to simulated function calling.
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
… APIs (elastic#208198)

## Summary

Follow-up of elastic#208144

The inference APIs can now detect if the underlying model / connector
supports native function calling using the `functionCalling: "auto"`
parameter. This PR adapts the calls done from the security assistant to
use that new value

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inference] automatic detection of native function calling support
4 participants