Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Cases] EUI Refresh: Change cases in progress status color #206240

Merged

Conversation

agusruidiazgd
Copy link
Contributor

@agusruidiazgd agusruidiazgd commented Jan 10, 2025

Summary

This PR resolves #205740
Change the In Progress badge to the hollow style to make it less prominent.

Screenshot 2025-01-10 at 10 45 46 Screenshot 2025-01-10 at 10 46 07

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Threat Hunting:Explore EUI Visual Refresh labels Jan 10, 2025
@agusruidiazgd agusruidiazgd self-assigned this Jan 10, 2025
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner January 10, 2025 09:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@joana-cps
Copy link

@agusruidiazgd 👋 I'm the designer from the RespOps team.
We use different colors for different statuses in cases. This serves to differentiate the ones that are open/closed/in-progress. Using the hollow style will just make it difficult to differentiate case statuses, especially when we're looking at cases table.

Although I understand the "make it less prominent" on the page, changing the badge to hollow is not the best solution for it.
Screenshot 2025-01-10 at 12 30 23
Screenshot 2025-01-10 at 12 23 00

We can agree to change the color of the In progress status in order to not use a warning color. Wdyt?

Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on behalf of @joana-cps 's comment

@joana-cps
Copy link

joana-cps commented Jan 15, 2025

@agusruidiazgd After reviewing this with @codearos, and discuss with the team, we agree on the following approach/changes.

Open should use success color
In Progress should use primary color

Screenshot 2025-01-15 at 12 45 38

This doesn't necessarily make the badge less prominent but removes the semantic meaning warning that the yellow currently brings and that we both agreed that it was misleading.

This is how these changes look in context:
cases-table-new-badges-color
cases-page-new-badges-color

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@agusruidiazgd
Copy link
Contributor Author

Thanks for your insights @joana-cps @codearos 😸
Quick update: Colors have been changed in order to match with design requests.

Theme Amsterdam:
Screenshot 2025-01-16 at 09 48 01
Screenshot 2025-01-16 at 09 47 35

Theme Borealis:
Screenshot 2025-01-16 at 09 49 05
Screenshot 2025-01-16 at 09 48 44

@agusruidiazgd agusruidiazgd enabled auto-merge (squash) January 17, 2025 11:14
@angorayc
Copy link
Contributor

@agusruidiazgd @joana-cps Please also check if we want to update the case table and the histogram in the detection response dashboard:
Screenshot 2025-01-21 at 18 19 45
Screenshot 2025-01-21 at 18 19 34

@joana-cps
Copy link

@agusruidiazgd @joana-cps Please also check if we want to update the case table and the histogram in the detection response dashboard:

Thanks @angorayc Yes, we should change it in every place that we use case status badges/colors and keep it consistent.

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@agusruidiazgd agusruidiazgd requested a review from a team as a code owner January 24, 2025 10:28
@agusruidiazgd
Copy link
Contributor Author

Updated detection & response page:

Screenshot 2025-01-24 at 11 29 32

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @agusruidiazgd

@agusruidiazgd agusruidiazgd merged commit 3805b46 into elastic:main Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases] Cases status for “in progress” too prominent
6 participants