Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Expand test coverage for performing rule field upgrades to all diffable fields #205339

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Dec 31, 2024

Partially resolves: #202078

NOTE: This PR builds, refactors (and corrects parts of) #205217. Only the last commit in this PR (dbb5b23) actually addresses the description mentioned below. All others belong to #205217. This PR will probably need a rebase after #205217 is merged.

Summary

  • Refactors and expands upgrade/_perform integrations tests in ALL_RULES and SPECIFIC_RULES to cover all diffable fields.
  • Extracts out all mock data for tests used for integration tests of both upgrade/_review and upgrade/_perform endpoints into its own file.

Flaky test run

🕐 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7638

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@jpdjere jpdjere changed the title Upgrade perfrom test enhancement [Security Solution] Expand test coverage for performing rule field upgrades to all diffable fields Dec 31, 2024
@jpdjere jpdjere self-assigned this Dec 31, 2024
@jpdjere jpdjere added test release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 labels Dec 31, 2024
@jpdjere jpdjere marked this pull request as ready for review December 31, 2024 19:48
@jpdjere jpdjere requested review from a team as code owners December 31, 2024 19:48
@jpdjere jpdjere requested a review from nikitaindik December 31, 2024 19:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@jpdjere jpdjere requested a review from maximpn December 31, 2024 19:51
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts ES|QL mode should send no more than 2 search requests (documents + chart) on page load

Metrics [docs]

✅ unchanged

cc @jpdjere

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7638

[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 75/100 tests passed.
[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/serverless.config.ts: 100/100 tests passed.

see run history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Tests for prebuilt rule upgrade workflow
3 participants