[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh #205338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluefinger
added
release_note:skip
|
/ci |
|
/ci |
|
/ci |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…mp based refresh (elastic#205338) ## Summary Refactoring `useSearchSession` to `useReloadRequestTime` to decouple the usage of search.session for refreshing, avoiding a re-rendering loop issue. This change is then propagated to various Lens charts to make use of that instead of relying on searchSessionId. Closes elastic#203412 ## How to test - Go to Infrastructure Inventory page in Observability - Enable Auto-Refresh - Click on a infra item (host/service/etc) to open the fly-out - Update the time range in the flyout - Things should update without spurious refreshes. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit fe988fa)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
…imestamp based refresh (#205338) (#205521) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh (#205338)](#205338) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T16:44:52Z","message":"[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh (#205338)\n\n## Summary\r\n\r\nRefactoring `useSearchSession` to `useReloadRequestTime` to decouple the\r\nusage of search.session for refreshing, avoiding a re-rendering loop\r\nissue. This change is then propagated to various Lens charts to make use\r\nof that instead of relying on searchSessionId.\r\n\r\nCloses #203412\r\n\r\n## How to test\r\n\r\n- Go to Infrastructure Inventory page in Observability\r\n- Enable Auto-Refresh\r\n- Click on a infra item (host/service/etc) to open the fly-out\r\n- Update the time range in the flyout\r\n- Things should update without spurious refreshes.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fe988fa55272a4ee6006a3a3ffc899a03fd4390c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh","number":205338,"url":"https://github.com/elastic/kibana/pull/205338","mergeCommit":{"message":"[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh (#205338)\n\n## Summary\r\n\r\nRefactoring `useSearchSession` to `useReloadRequestTime` to decouple the\r\nusage of search.session for refreshing, avoiding a re-rendering loop\r\nissue. This change is then propagated to various Lens charts to make use\r\nof that instead of relying on searchSessionId.\r\n\r\nCloses #203412\r\n\r\n## How to test\r\n\r\n- Go to Infrastructure Inventory page in Observability\r\n- Enable Auto-Refresh\r\n- Click on a infra item (host/service/etc) to open the fly-out\r\n- Update the time range in the flyout\r\n- Things should update without spurious refreshes.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fe988fa55272a4ee6006a3a3ffc899a03fd4390c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205338","number":205338,"mergeCommit":{"message":"[Infra] Refactor useSearchSession to useReloadRequestTime for timestamp based refresh (#205338)\n\n## Summary\r\n\r\nRefactoring `useSearchSession` to `useReloadRequestTime` to decouple the\r\nusage of search.session for refreshing, avoiding a re-rendering loop\r\nissue. This change is then propagated to various Lens charts to make use\r\nof that instead of relying on searchSessionId.\r\n\r\nCloses #203412\r\n\r\n## How to test\r\n\r\n- Go to Infrastructure Inventory page in Observability\r\n- Enable Auto-Refresh\r\n- Click on a infra item (host/service/etc) to open the fly-out\r\n- Update the time range in the flyout\r\n- Things should update without spurious refreshes.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fe988fa55272a4ee6006a3a3ffc899a03fd4390c"}}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring
useSearchSessiontouseReloadRequestTimeto decouple the usage of search.session for refreshing, avoiding a re-rendering loop issue. This change is then propagated to various Lens charts to make use of that instead of relying on searchSessionId.Closes #203412
How to test