-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storybook for kibana management #205299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]
|
mattkime
added
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
labels
Dec 30, 2024
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
added
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
release_note:skip
Skip the PR/issue when compiling release notes
labels
Dec 30, 2024
SoniaSanzV
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Storybook broke due to recent file reorganized, this fixes it. `yarn storybook management` will start storybook with kibana management team content. <img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM" src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5" /> (cherry picked from commit 1f8d841)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Storybook broke due to recent file reorganized, this fixes it. `yarn storybook management` will start storybook with kibana management team content. <img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM" src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5" />
kibanamachine
added a commit
that referenced
this pull request
Jan 2, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Fix storybook for kibana management (#205299)](#205299) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T13:24:08Z","message":"Fix storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn storybook management` will start storybook with kibana management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot 2024-12-30 at 5 34 48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix storybook for kibana management","number":205299,"url":"https://github.com/elastic/kibana/pull/205299","mergeCommit":{"message":"Fix storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn storybook management` will start storybook with kibana management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot 2024-12-30 at 5 34 48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205299","number":205299,"mergeCommit":{"message":"Fix storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn storybook management` will start storybook with kibana management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot 2024-12-30 at 5 34 48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Storybook broke due to recent file reorganized, this fixes it. `yarn storybook management` will start storybook with kibana management team content. <img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM" src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Storybook broke due to recent file reorganized, this fixes it.
yarn storybook management
will start storybook with kibana management team content.