Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook for kibana management #205299

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Dec 30, 2024

Summary

Storybook broke due to recent file reorganized, this fixes it.

yarn storybook management will start storybook with kibana management team content.

Screenshot 2024-12-30 at 5 34 48 PM

@mattkime mattkime marked this pull request as ready for review December 30, 2024 20:37
@mattkime mattkime requested a review from a team as a code owner December 30, 2024 20:37
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@mattkime mattkime self-assigned this Dec 30, 2024
@mattkime mattkime added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime mattkime added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Dec 30, 2024
@mattkime mattkime changed the title fix storybook Fix storybook for kibana management Dec 30, 2024
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM ☺️

@mattkime mattkime merged commit 1f8d841 into elastic:main Jan 2, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12583129205

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
## Summary

Storybook broke due to recent file reorganized, this fixes it.

`yarn storybook management` will start storybook with kibana management
team content.

<img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM"
src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5"
/>

(cherry picked from commit 1f8d841)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 2, 2025
## Summary

Storybook broke due to recent file reorganized, this fixes it.

`yarn storybook management` will start storybook with kibana management
team content.

<img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM"
src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5"
/>
kibanamachine added a commit that referenced this pull request Jan 2, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix storybook for kibana management
(#205299)](#205299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T13:24:08Z","message":"Fix
storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook
broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn
storybook management` will start storybook with kibana
management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot
2024-12-30 at 5 34
48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix
storybook for kibana
management","number":205299,"url":"https://github.com/elastic/kibana/pull/205299","mergeCommit":{"message":"Fix
storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook
broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn
storybook management` will start storybook with kibana
management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot
2024-12-30 at 5 34
48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205299","number":205299,"mergeCommit":{"message":"Fix
storybook for kibana management (#205299)\n\n## Summary\r\n\r\nStorybook
broke due to recent file reorganized, this fixes it.\r\n\r\n`yarn
storybook management` will start storybook with kibana
management\r\nteam content.\r\n\r\n<img width=\"790\" alt=\"Screenshot
2024-12-30 at 5 34
48 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5\"\r\n/>","sha":"1f8d841a5743335d78af2779a864c3c4f0848b5e"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
## Summary

Storybook broke due to recent file reorganized, this fixes it.

`yarn storybook management` will start storybook with kibana management
team content.

<img width="790" alt="Screenshot 2024-12-30 at 5 34 48 PM"
src="https://github.com/user-attachments/assets/d94637b5-cd0d-4dbc-8d25-6ed4c15d82d5"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants