Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User] Prevent disabled input change by password manager #204269

Merged
merged 8 commits into from
Jan 9, 2025
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { fireEvent, render, screen } from '@testing-library/react';
import { createMemoryHistory } from 'history';
import React from 'react';

import { coreMock } from '@kbn/core/public/mocks';

import type { UserFormProps, UserFormValues } from './user_form';
import { UserForm } from './user_form';
import { securityMock } from '../../../mocks';
import { Providers } from '../users_management_app';

const userMock: UserFormValues = {
username: 'jdoe',
full_name: '',
email: '',
roles: ['superuser'],
};

describe('UserForm', () => {
const coreStart = coreMock.createStart();
const authc = securityMock.createSetup().authc;
const history = createMemoryHistory({ initialEntries: ['/edit/jdoe'] });

const onCancelMock = jest.fn();
const onSuccessMock = jest.fn();

let defaultProps: UserFormProps;

beforeEach(() => {
defaultProps = {
isNewUser: true,
isReservedUser: false,
isCurrentUser: false,
defaultValues: userMock,
onCancel: onCancelMock,
onSuccess: onSuccessMock,
disabled: false,
};
});

const renderUserForm = (props: Partial<UserFormProps> = {}) => {
return render(
<Providers services={coreStart} authc={authc} history={history}>
<UserForm {...defaultProps} {...props} />
</Providers>
);
};

it('prevents editing username when disabled', async () => {
// See https://github.com/elastic/kibana/issues/204268

renderUserForm({ disabled: true });
const usernameInput = screen.getByTestId<HTMLInputElement>('userFormUserNameInput');
fireEvent.change(usernameInput, { target: { value: 'foo' } });
expect(usernameInput.value).toBe('jdoe');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export const UserForm: FunctionComponent<UserFormProps> = ({
isLoading={form.isValidating}
isInvalid={form.touched.username && !!form.errors.username}
disabled={disabled || !isNewUser}
onChange={eventHandlers.onChange}
onChange={disabled || !isNewUser ? undefined : eventHandlers.onChange}
onBlur={eventHandlers.onBlur}
/>
</EuiFormRow>
Expand Down
Loading