Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the button for saving theme in the profile primary #204141

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ek-so
Copy link
Contributor

@ek-so ek-so commented Dec 12, 2024

Summary

Within the upcoming EUI update (to use Borealis), we revise some use cases for colors and component variants associated with them. In this case, it looks a bit strange and also inconsistent that we are saving something with success button, so it was changed to primary.
CleanShot 2024-12-12 at 23 15 50@2x

@ek-so
Copy link
Contributor Author

ek-so commented Dec 12, 2024

It also aligns with our general direction wdyt @ryankeairns?

@ek-so ek-so marked this pull request as ready for review December 13, 2024 08:32
@ek-so ek-so requested a review from a team as a code owner December 13, 2024 08:32
@ek-so ek-so added the backport label Dec 13, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ek-so ek-so merged commit 1afe6bb into elastic:main Dec 13, 2024
10 checks passed
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Dec 13, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
## Summary
Within the [upcoming EUI update (to use
Borealis)](elastic#199715), we revise
some use cases for colors and component variants associated with them.
In this case, it looks a bit strange and also inconsistent that we are
saving something with success button, so it was changed to primary.
![CleanShot 2024-12-12 at 23 15
50@2x](https://github.com/user-attachments/assets/dcd0185f-69f5-4879-abea-a60c614b9019)
@ek-so ek-so deleted the borealis-testing branch January 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting backport v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants