Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Connector selector onboarding #203742

Merged

Conversation

agusruidiazgd
Copy link
Contributor

@agusruidiazgd agusruidiazgd commented Dec 11, 2024

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Screen.Recording.2024-12-13.at.14.33.56.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd self-assigned this Dec 11, 2024
@agusruidiazgd agusruidiazgd added v8.18.0 Team:Threat Hunting:Explore release_note:skip Skip the PR/issue when compiling release notes v9.0.0 ci:cloud-deploy Create or update a Cloud deployment labels Dec 16, 2024
@agusruidiazgd agusruidiazgd marked this pull request as ready for review December 16, 2024 08:45
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner December 16, 2024 08:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

semd
semd previously approved these changes Dec 16, 2024
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@semd semd added the backport:version Backport to applied version labels label Dec 16, 2024
@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@agusruidiazgd
Copy link
Contributor Author

/ci

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@agusruidiazgd
Copy link
Contributor Author

/ci

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! there's only a few things:

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

History

cc @agusruidiazgd

@agusruidiazgd agusruidiazgd requested a review from semd January 24, 2025 10:04
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @agusruidiazgd!

@agusruidiazgd agusruidiazgd merged commit 86666bf into elastic:main Jan 24, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12949933445

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203742

Questions ?

Please refer to the Backport tool documentation

@agusruidiazgd
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

agusruidiazgd added a commit to agusruidiazgd/kibana that referenced this pull request Jan 24, 2025
## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

https://github.com/user-attachments/assets/6d7527d1-dc8d-4f3a-9b03-cfd0022701d2

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 86666bf)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/solutions/security/plugins/security_solution/public/onboarding/components/onboarding_body/cards/common/connectors/connector_setup.tsx
agusruidiazgd added a commit that referenced this pull request Jan 24, 2025
…08205)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Connector selector onboarding
(#203742)](#203742)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Agustina Nahir
Ruidiaz","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-24T12:47:41Z","message":"[Security
Solution] Connector selector onboarding (#203742)\n\n##
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot
or\r\ngif.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d7527d1-dc8d-4f3a-9b03-cfd0022701d2\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"86666bf790c87ee8bde353d53dcf5413e80e50e5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Explore","ci:cloud-deploy","backport:version","v8.18.0"],"title":"[Security
Solution] Connector selector
onboarding","number":203742,"url":"https://github.com/elastic/kibana/pull/203742","mergeCommit":{"message":"[Security
Solution] Connector selector onboarding (#203742)\n\n##
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot
or\r\ngif.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d7527d1-dc8d-4f3a-9b03-cfd0022701d2\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"86666bf790c87ee8bde353d53dcf5413e80e50e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203742","number":203742,"mergeCommit":{"message":"[Security
Solution] Connector selector onboarding (#203742)\n\n##
Summary\r\n\r\nSummarize your PR. If it involves visual changes include
a screenshot
or\r\ngif.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d7527d1-dc8d-4f3a-9b03-cfd0022701d2\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"86666bf790c87ee8bde353d53dcf5413e80e50e5"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants