Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET documentation #203391

Merged

Conversation

stevejgordon
Copy link
Contributor

Summary

This PR updates our quick starts for .NET to use the latest preferred methods. I have been unable to get this running locally. If it's possible for an approver to check it renders correctly, that would be ideal. Otherwise, I can look at getting a VM set up so I can try to build Kibana and run it in that environment.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

None

@stevejgordon stevejgordon requested a review from a team as a code owner December 9, 2024 11:16
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevejgordon stevejgordon enabled auto-merge (squash) February 3, 2025 11:37
@stevejgordon stevejgordon force-pushed the dotnet-documentation-updates branch from 9fc103e to 58503f2 Compare February 3, 2025 12:10
@stevejgordon stevejgordon added release_note:skip Skip the PR/issue when compiling release notes backport:8.17 backport:skip This commit does not require backporting and removed backport:8.17 labels Feb 3, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 3, 2025

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 58503f2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203391-58503f2937ba

Failed CI Steps

Test Failures

  • [job] [logs] APM Cypress Tests #1 / Mobile transactions page when data is loaded when click on tab shows correct table shows version tab shows version tab

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.0MB 4.0MB -362.0B

History

@stevejgordon stevejgordon merged commit 1d1599e into elastic:main Feb 3, 2025
16 checks passed
@stevejgordon stevejgordon deleted the dotnet-documentation-updates branch February 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants