-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for High Contrast Mode, ResponseOps domains #202610
Merged
tsullivan
merged 8 commits into
elastic:main
from
tsullivan:user-profile-service/005-responseops
Dec 12, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0c7a693
Preparation for High Contrast Mode, ResponseOps domains
tsullivan 4adfed1
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine da52b0b
Destructure the params used for useMemo
tsullivan cae5f34
Merge branch 'main' into user-profile-service/005-responseops
tsullivan 8642917
Merge branch 'main' into user-profile-service/005-responseops
tsullivan d3b2b94
Merge branch 'main' into user-profile-service/005-responseops
tsullivan ee81d77
Merge branch 'main' into user-profile-service/005-responseops
tsullivan bbbd1f1
Merge branch 'main' into user-profile-service/005-responseops
tsullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,7 +106,7 @@ const getErrorMessage = (error: Error | ServerError): string => { | |
|
||
export const useCasesToast = () => { | ||
const { appId } = useApplication(); | ||
const { application, i18n, theme } = useKibana().services; | ||
const { application, i18n, theme, userProfile } = useKibana().services; | ||
const { getUrlForApp, navigateToUrl } = application; | ||
|
||
const toasts = useToasts(); | ||
|
@@ -148,13 +148,13 @@ export const useCasesToast = () => { | |
return toasts.addSuccess({ | ||
color: 'success', | ||
iconType: 'check', | ||
title: toMountPoint(<TruncatedText text={renderTitle} />, { i18n, theme }), | ||
title: toMountPoint(<TruncatedText text={renderTitle} />, { i18n, theme, userProfile }), | ||
text: toMountPoint( | ||
<CaseToastSuccessContent | ||
content={renderContent} | ||
onViewCaseClick={url != null ? onViewCaseClick : undefined} | ||
/>, | ||
{ i18n, theme } | ||
{ i18n, theme, userProfile } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not passing a large object here for the services, because this is within a |
||
), | ||
}); | ||
}, | ||
|
@@ -177,7 +177,7 @@ export const useCasesToast = () => { | |
}); | ||
}, | ||
}), | ||
[i18n, theme, appId, getUrlForApp, navigateToUrl, toasts] | ||
[i18n, theme, userProfile, appId, getUrlForApp, navigateToUrl, toasts] | ||
); | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire
CoreStart
object is passed as part of theplugins
object, so I destructured the params that are needed for theRuleFormPlugins
interface, since this is in auseMemo
. React watches these dependencies to rerender theRuleForm
component when they change.