[Cases] Cases assignees sub feature #201654

kqualters-elastic · 2024-11-25T17:16:05Z

Summary

This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden.

Read only + enabled:

All + assign disabled:

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2024-12-12T22:03:12Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-12-12T22:03:13Z

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

kqualters-elastic · 2025-01-29T23:00:04Z

@kc13greiner updated

...plugins/shared/features/server/feature_privilege_iterator/feature_privilege_iterator.test.ts

kc13greiner · 2025-01-30T01:46:55Z

x-pack/test/api_integration/apis/cases/privileges.ts

+        user: obsCasesOnlyDeleteUser,
+        owner: OBSERVABILITY_APP_ID,
+        userWithFullPerms: obsCasesAllUser,
+      },


Nit: I think V3 variants of users: casesNoDelete, obsCasesNoDelete, and secAllCasesNoDelete (the names are sort of misleading, the have the minimal_all privilege) should be added here.

kc13greiner · 2025-01-30T01:48:11Z

x-pack/test/api_integration/apis/cases/privileges.ts

+      { user: obsCasesV2AllUser, owner: OBSERVABILITY_APP_ID },
+      { user: secCasesV3AllUser, owner: SECURITY_SOLUTION_APP_ID },
+      { user: casesV3AllUser, owner: CASES_APP_ID },
+      { user: obsCasesV3AllUser, owner: OBSERVABILITY_APP_ID },


Nit: I think V1 and V2 variants of users: casesNoDelete, obsCasesNoDelete, and secAllCasesNoDelete (the names are sort of misleading, the have the minimal_all privilege) should be added here.

that I agree with, I think I was just trying to avoid a permutation explosion in these test names, this is quickly going to become untenable how it currently works, i.e. secCasesV3MinAllWithSettingsWithoutCommentWithReopenWithoutDeleteWithAssign ha

kc13greiner · 2025-01-30T01:51:18Z

@kc13greiner ya I updated the 2 solution definitions as well, all should be in sync. As for the tests, since these are ultimately just a static blob of json, there aren't really any unit level tests that 'know' exactly what should/shouldn't be in each, as the json blob is the source of truth itself. I've just been relying on the integration tests in x-pack/test/api_integration/apis/cases, x-pack/test/cases_api_integration, & x-pack/test/security_api_integration/tests/features, with most in x-pack/test/api_integration/apis/cases, although clearly there's not a test that should have been failing for that improper configuration I had in this pr for a while now.

@kqualters-elastic I found the tests I was looking for 👍 I added a few suggestions to help cover the minimal_all

Changes to the the V1/2/3 of all types LGTM.

Thank you for making all those changes!

kc13greiner

Left a few suggestions above for improved test coverage of minimal_all

Overall LGTM - great work!

michaelolo24 · 2025-01-30T14:20:25Z

@elasticmachine merge upstream

elasticmachine · 2025-01-30T15:30:10Z

💚 Build Succeeded

Buildkite Build
Commit: f9fd4d9
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201654-f9fd4d9a9e9e

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`cases`	105	109	+4
`observability`	689	690	+1
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	540.5KB	540.8KB	+263.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	162.2KB	162.5KB	+318.0B
`observability`	102.1KB	102.1KB	+74.0B
`observabilityShared`	93.9KB	93.9KB	+20.0B
total			+412.0B

Unknown metric groups

API count

id	before	after	diff
`cases`	125	129	+4
`observability`	697	698	+1
total			+5

ESLint disabled line counts

id	before	after	diff
`cases`	63	64	+1

References to deprecated APIs

id	before	after	diff
`ml`	57	60	+3

Total ESLint disabled count

id	before	after	diff
`cases`	81	82	+1

History

💔 Build #271846 failed e9d4f33
💚 Build #271840 succeeded 0a09c89
💔 Build #271823 failed cbef6bf
💚 Build #271801 succeeded 547e024
💚 Build #271332 succeeded 7437b84

kibanamachine · 2025-01-30T16:04:54Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13056276893

kibanamachine · 2025-01-30T16:10:40Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 201654

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2025-02-03T16:49:49Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 201654 locally

kobelb · 2025-02-03T21:43:42Z

I just updated the labels on this PR. It didn't merge before the 9.0/8.18 feature freeze, and the backport to 8.x failed. Right now, this change will only be included in 9.1. I'm assuming that we'll be fixing the backport, so I added the 8.19 label.

kqualters-elastic · 2025-02-04T02:29:45Z

💚 All backports created successfully

Status	Branch	Result
✅	8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kqualters-elastic · 2025-02-04T02:41:44Z

💔 Some backports could not be created

Status	Branch	Result
❌	9.0	Cherrypick failed because the selected commit (`0e7c608`) is empty. Did you already backport this commit?
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 201654

Questions ?

Please refer to the Backport tool documentation

## Summary This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 0e7c608) # Conflicts: # x-pack/platform/plugins/shared/cases/server/client/cases/bulk_update.test.ts # x-pack/platform/plugins/shared/features/server/__snapshots__/oss_features.test.ts.snap # x-pack/test/api_integration/apis/cases/common/roles.ts # x-pack/test/api_integration/apis/cases/common/users.ts # x-pack/test/api_integration/apis/cases/privileges.ts # x-pack/test/security_api_integration/tests/features/deprecated_features.ts # x-pack/test/spaces_api_integration/common/suites/get.ts

kqualters-elastic · 2025-02-04T02:57:58Z

@kobelb I think it made it in to 9.0 bc1, but not 8.18: https://github.com/elastic/kibana/commits/fd1f8b62137f14e93716e298e4e931b576e2ca13 for 9.0 vs
https://github.com/elastic/kibana/commits/33e6754d67870b0e403266b752c3973539506cc6 for 8.18 (and as the backport above is still open). The 8.18 backport in particular gave me a bunch of issues locally, and now is failing on buildkite with an error that seems completely unrelated:

ERROR Failed to capture OAS: {
--
  | "errno": -28,
  | "code": "ENOSPC",
  | "syscall": "mkdir",
  | "path": "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1738636880036796160/elastic/kibana-pull-request/kibana/.es/es-test-cluster/ES_TMPDIR"
  | }
  | ERROR UNHANDLED ERROR
  | ERROR Error: ENOSPC: no space left on device, mkdir '/opt/buildkite-agent/builds/bk-agent-prod-gcp-1738636880036796160/elastic/kibana-pull-request/kibana/.es/es-test-cluster/ES_TMPDIR'

I think it would be ok to include in 8.18 BC2 as long as CI passes eventually, given that it's in 9.0 already, but if anyone disagrees I can close it.

kqualters-elastic added 3 commits November 25, 2024 05:57

WIP stack v3 cases working

0c5ab06

Merge branch 'main' into cases-assignees

994389d

Merge remote-tracking branch 'upstream/main' into cases-assignees

2fc8550

kqualters-elastic added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.18.0 labels Nov 25, 2024

kqualters-elastic added 6 commits December 2, 2024 15:40

Merge remote-tracking branch 'upstream/main' into cases-assignees

81791a8

Add sec/obs case assignee sub feature + tests

3318b46

Merge remote-tracking branch 'upstream/main' into cases-assignees

ceeb37c

Fix tests and i18n warning

86f2829

Merge remote-tracking branch 'upstream/main' into cases-assignees

12bd761

Fix types

fbb8427

kqualters-elastic changed the title ~~[WIP] [Cases] Cases assignees~~ [Cases] Cases assignees sub feature Dec 12, 2024

Merge remote-tracking branch 'upstream/main' into cases-assignees

dc2a26d

kqualters-elastic marked this pull request as ready for review December 12, 2024 22:03

kqualters-elastic requested review from a team as code owners December 12, 2024 22:03

kqualters-elastic added the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Dec 12, 2024

Move security cases priv definition to right location

d3ac4f2

botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 12, 2024

Merge remote-tracking branch 'upstream/main' into cases-assignees

cbef6bf

kqualters-elastic added 2 commits January 29, 2025 19:32

Update new snapshots

b9a8de8

Merge remote-tracking branch 'upstream/main' into cases-assignees

0a09c89

kc13greiner reviewed Jan 30, 2025

View reviewed changes

...plugins/shared/features/server/feature_privilege_iterator/feature_privilege_iterator.test.ts Outdated Show resolved Hide resolved

kc13greiner reviewed Jan 30, 2025

View reviewed changes

Add new subfeatures to feature privileges tests

e9d4f33

kc13greiner approved these changes Jan 30, 2025

View reviewed changes

Merge branch 'main' into cases-assignees

f9fd4d9

kqualters-elastic enabled auto-merge (squash) January 30, 2025 16:03

kqualters-elastic merged commit 0e7c608 into elastic:main Jan 30, 2025
9 checks passed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 3, 2025

kobelb added v8.19.0 v9.1.0 and removed v8.18.0 v9.0.0 labels Feb 3, 2025

kqualters-elastic mentioned this pull request Feb 4, 2025

[8.18] [Cases] Cases assignees sub feature (#201654) #209435

Open

kqualters-elastic mentioned this pull request Feb 4, 2025

[8.x] [Cases] Cases assignees sub feature (#201654) #209437

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Cases assignees sub feature #201654

[Cases] Cases assignees sub feature #201654

kqualters-elastic commented Nov 25, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Dec 12, 2024

elasticmachine commented Dec 12, 2024

kqualters-elastic commented Jan 29, 2025

kc13greiner Jan 30, 2025

kc13greiner Jan 30, 2025

kqualters-elastic Jan 30, 2025

kc13greiner commented Jan 30, 2025

kc13greiner left a comment

michaelolo24 commented Jan 30, 2025

elasticmachine commented Jan 30, 2025 •

edited

Loading

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

kibanamachine commented Jan 30, 2025

kibanamachine commented Jan 30, 2025

kibanamachine commented Feb 3, 2025

kobelb commented Feb 3, 2025 •

edited

Loading

kqualters-elastic commented Feb 4, 2025

kqualters-elastic commented Feb 4, 2025

kqualters-elastic commented Feb 4, 2025

[Cases] Cases assignees sub feature #201654

[Cases] Cases assignees sub feature #201654

Conversation

kqualters-elastic commented Nov 25, 2024 • edited by kibanamachine Loading

Summary

Checklist

elasticmachine commented Dec 12, 2024

elasticmachine commented Dec 12, 2024

kqualters-elastic commented Jan 29, 2025

kc13greiner Jan 30, 2025

Choose a reason for hiding this comment

kc13greiner Jan 30, 2025

Choose a reason for hiding this comment

kqualters-elastic Jan 30, 2025

Choose a reason for hiding this comment

kc13greiner commented Jan 30, 2025

kc13greiner left a comment

Choose a reason for hiding this comment

michaelolo24 commented Jan 30, 2025

elasticmachine commented Jan 30, 2025 • edited Loading

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

kibanamachine commented Jan 30, 2025

kibanamachine commented Jan 30, 2025

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Feb 3, 2025

kobelb commented Feb 3, 2025 • edited Loading

kqualters-elastic commented Feb 4, 2025

💚 All backports created successfully

Questions ?

kqualters-elastic commented Feb 4, 2025

💔 Some backports could not be created

Manual backport

Questions ?

kqualters-elastic commented Feb 4, 2025

kqualters-elastic commented Nov 25, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Jan 30, 2025 •

edited

Loading

kobelb commented Feb 3, 2025 •

edited

Loading