[Reporting] Enable CI test coverage for generated PDFs #191559
Draft
+145
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
force-pushed
the
screenshotting/pdf-test-coverage
branch
from
d4b37e5 to
4cf61d5
Compare
tsullivan
force-pushed
the
screenshotting/pdf-test-coverage
branch
from
58fc6ad to
aaaebe6
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
commented
Aug 28, 2024
| await comparePdf(sessionReportPath, baselinePath, { | ||
| compareThreshold: 0.035, | ||
| }) | ||
| ).to.be(true); |
There was a problem hiding this comment.
I'm not satisfied that a test failure yields the message Expected "false" to be "true", unfortunately it isn't the nature of pdf-visual-compare to yield an actual percentage of difference. That is something we do get with the compare PNG method. This PR should be reworked to use something more like an older solution that was previously explored.
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #117814
Revival of #113910
Blocked by https://github.com/elastic/kibana-operations/issues/193
This PR introduces https://github.com/dichovsky/pdf-visual-compare to the dev dependencies, and adds a single test to verify a PDF from the Dashboard app. If successful, we will add more tests that include multi-page PDF, and cover Canvas app and more.
STATUS: Since the module introduced in this PR has an indirect dependency on node-canvas, this is blocked on a request with @elastic/kibana-operations to make node-canvas prebuilds available to Kibana developers. Without that, node-canvas would require prebuilds to compile locally which creates a negative experience for developers.