-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v95.3.0 #187342
Upgrade EUI to v95.3.0 #187342
Conversation
buildkite test this |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @tkajtoch |
@tkajtoch this fix will be available in version 8.15.0 ? when can we expect this release? |
Pinging @elastic/eui-team (EUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/dev/license_checker/config.ts
'euiFilePicker.removeSelectedAriaLabel': i18n.translate( | ||
'core.euiFilePicker.removeSelectedAriaLabel', | ||
{ | ||
defaultMessage: 'Remove selected files', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this copy changed from Clear
to Remove
? I don't think this functionality deletes anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change comes from elastic/eui#7860 and originated in https://github.com/elastic/observability-dev/issues/3641.
The Remove
EuiFilePicker button previously had an ARIA label, Clear selected files
, that didn't match the button's displayed label. Now, the ARIA label matches the display label better. I agree that the usage of remove
here could sometimes be misleading, but considering this button is only visible when you select a file from disk, it does make sense.
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
cc @tkajtoch |
@elasticmachine merge upstream |
`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([elastic#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([elastic#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([elastic#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([elastic#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([elastic#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([elastic#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([elastic#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
## Backport This is a manual backport of EUI v95.3.0 (#187342) which was intended to target 8.15 but was missed due to the `backport:skip` label. The release contains a requested visual bugfix for Chromium users: elastic/eui#7855 (comment) Co-authored-by: Tomasz Kajtoch <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
v95.2.0
⏩v95.3.0
Questions? Please see our Kibana upgrade FAQ.
v95.3.0
EuiThemeProvider
s to allow modifying/setting custombreakpoint
s in nested usage (as opposed to only at the topEuiProvider
level) (#7862)Bug fixes
mask-image
bug that was affecting scroll overflow shadow utilties (#7855)CSS-in-JS conversions
EuiColorPicker
to Emotion; Removed$euiColorPickerWidth
(#7845)EuiColorPickerSwatch
to Emotion (#7853)EuiColorPalettePicker
andEuiColorPaletteDisplay
to Emotion (#7854)$euiColorPaletteDisplaySizes
@mixin euiColorPaletteInnerBorder
$euiColorPickerValueRange0
,$euiColorPickerValueRange1
,$euiColorPickerSaturationRange0
,$euiColorPickerSaturationRange1
, and$euiColorPickerIndicatorSize
(#7859)Accessibility
aria-label
attribute for theEuiFilePicker
remove file button (#7860)