Fixing flaky find tests
#183746
Merged
Fixing flaky find tests
#183746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Alerting
release_note:skip
|
@elasticmachine merge upstream |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6032[✅] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 200/200 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
reviewed
May 19, 2024
| // Failing: See https://github.com/elastic/kibana/issues/182263 | ||
| // Failing: See https://github.com/elastic/kibana/issues/182284 | ||
| describe.skip('find', () => { | ||
| describe('find', () => { | ||
| const objectRemover = new ObjectRemover(supertest); | ||
|
|
||
| afterEach(() => objectRemover.removeAll()); |
There was a problem hiding this comment.
Should we make the function async?
cnasikas
reviewed
May 19, 2024
| @@ -19,14 +19,12 @@ const findTestUtils = ( | |||
| supertest: SuperTestAgent, | |||
| supertestWithoutAuth: any | |||
| ) => { | |||
| // FLAKY: https://github.com/elastic/kibana/issues/182314 | |||
| describe.skip(describeType, () => { | |||
| describe(describeType, () => { | |||
| afterEach(() => objectRemover.removeAll()); | |||
There was a problem hiding this comment.
Should we make the function async?
cnasikas
approved these changes
May 19, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182263
Resolves #182284
Resolves #182314
Summary
Missing
awaitin the backfill tests caused a rule created for those tests not to finish getting deleted before thefindtests ran