Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableSoftLineBreaks to shared-ux-markdown #182635

Merged
merged 5 commits into from
May 13, 2024

Conversation

sakurai-youhei
Copy link
Member

@sakurai-youhei sakurai-youhei commented May 6, 2024

Summary

This PR adds an enableSoftLineBreaks parameter to the <Markdown> component in shared-ux, which enables it to fill the gap in line breaking between the legacy React <Markdown> component.

enableSoftLineBreaks

The parameter defaults to false not to change the current behavior in existing use cases. Furthermore, there is currently no case where the parameter is set to true because of #180906.

Closes #180576

Checklist

For maintainers

@sakurai-youhei sakurai-youhei added Feature:Markdown Markdown visualization feature release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 6, 2024
@sakurai-youhei sakurai-youhei marked this pull request as ready for review May 6, 2024 08:48
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner May 6, 2024 08:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-ux-markdown-mocks 31 40 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +33.0B
controls 231.3KB 231.4KB +99.0B
discover 636.4KB 636.5KB +33.0B
expressionError 14.4KB 14.4KB +33.0B
lens 1.4MB 1.4MB +33.0B
textBasedLanguages 167.3KB 167.3KB +33.0B
visTypeTimeseries 512.6KB 512.7KB +33.0B
visualizations 285.6KB 285.6KB +33.0B
total +330.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
banners 10.4KB 10.4KB +33.0B
presentationPanel 43.2KB 43.2KB +33.0B
total +66.0B
Unknown metric groups

API count

id before after diff
@kbn/shared-ux-markdown-mocks 32 41 +9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sakurai-youhei sakurai-youhei merged commit 0fa9008 into elastic:main May 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Markdown Markdown visualization feature release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Markdown] Consecutive lines are broken by line separators
4 participants