Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13] revert change to shared UX markdown component for dashboard vis (#180906) #181517

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

eokoneyo
Copy link
Contributor

Backport

This will backport the following commits from main to 8.13:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Eyo O. Eyo <[email protected]>"}},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/180906","number":180906,"mergeCommit":{"message":"revert change to shared UX markdown component for dashboard vis (#180906)\n\n## Summary\r\n\r\nThis PR reverts the change to the shared UX markdown component that\r\nhappened here https://github.com//pull/176478. The\r\naforementioned PR introduced couple of visual issues that were uncaught\r\nduring the migration.\r\n\r\nThe known issues that have been brought up that informed the decision to\r\nrevert this change, are itemised below;\r\n\r\n- https://github.com//issues/180576\r\n- https://github.com//issues/180452\r\n- https://github.com/elastic/sdh-kibana/issues/4608\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4127163bd913dccfbd17badbb9ce1a7a5b2afadc"}}]}] BACKPORT-->

…tic#180906)

## Summary

This PR reverts the change to the shared UX markdown component that
happened here elastic#176478. The
aforementioned PR introduced couple of visual issues that were uncaught
during the migration.

The known issues that have been brought up that informed the decision to
revert this change, are itemised below;

- elastic#180576
- elastic#180452
- elastic/sdh-kibana#4608

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 4127163)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / endpoint Endpoint Exceptions should add event.module=endpoint to entry if only wildcard operator is present

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeMarkdown 21 19 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeMarkdown 7.0KB 5.8KB -1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeMarkdown 6.9KB 7.0KB +141.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo eokoneyo added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo eokoneyo requested a review from a team April 24, 2024 08:28
@eokoneyo eokoneyo merged commit 7a1f691 into elastic:8.13 Apr 24, 2024
22 checks passed
@eokoneyo eokoneyo deleted the backport/8.13/pr-180906 branch April 24, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants