Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability AI Assistant] Fix double plusses #177314

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Feb 20, 2024

Summary

While we wait for elastic/eui#7524 to get merged into Eui, this adds the same icon into the sidebar:

Screenshot 2024-02-20 at 17 13 36

@CoenWarmer CoenWarmer requested a review from a team as a code owner February 20, 2024 15:55
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.13.0 labels Feb 20, 2024
@CoenWarmer CoenWarmer enabled auto-merge (squash) February 20, 2024 17:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 173.9KB 174.7KB +817.0B

History

  • 💛 Build #194426 was flaky 0dc5e805e5e705aacd7ff981ebf422babe34d72e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit f21bee4 into elastic:main Feb 21, 2024
16 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 21, 2024
…7471)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Observability AI Assistant] Fix double plusses
(#177314)](#177314)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-21T15:47:03Z","message":"[Observability
AI Assistant] Fix double plusses
(#177314)","sha":"f21bee44a8b9839e7bc332cc9bbde5c48c3b69e9","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.13.0","v8.14.0"],"title":"[Observability
AI Assistant] Fix double
plusses","number":177314,"url":"https://github.com/elastic/kibana/pull/177314","mergeCommit":{"message":"[Observability
AI Assistant] Fix double plusses
(#177314)","sha":"f21bee44a8b9839e7bc332cc9bbde5c48c3b69e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177314","number":177314,"mergeCommit":{"message":"[Observability
AI Assistant] Fix double plusses
(#177314)","sha":"f21bee44a8b9839e7bc332cc9bbde5c48c3b69e9"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <[email protected]>
@CoenWarmer CoenWarmer deleted the feat/new-chat-icon branch February 21, 2024 22:04
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants