Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability AI Assistant] Keep Chat Open On Navigation, use Resizable Flyout, allow Push and Overlay modes in Flyout #177127

Merged
merged 16 commits into from
Mar 19, 2024
Merged

[Observability AI Assistant] Keep Chat Open On Navigation, use Resizable Flyout, allow Push and Overlay modes in Flyout #177127

merged 16 commits into from
Mar 19, 2024

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Feb 17, 2024 •
edited
Loading

Summary

This adds the following:

  • incorporates the Eui Resizable Flyout, allowing the user to resize the flyout.
  • adds a button to the flyout to toggle the flyout mode from overlay to push mode.
  • When in 'push' mode, the chat conversation is kept in view and does not block the page, enabling the user to multitask between using the UI and chatting with the Assistant.

What it looks like

Screen.Recording.2024-02-17.at.01.49.26_small.mov

@CoenWarmer CoenWarmer requested review from a team as code owners February 17, 2024 00:56
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Feb 17, 2024
@CoenWarmer CoenWarmer force-pushed the feat/keep-flyout-useable branch from e4cf83c to 427f502 Compare February 17, 2024 01:03
@CoenWarmer CoenWarmer force-pushed the feat/keep-flyout-useable branch from b8dc67e to 944fd88 Compare February 17, 2024 10:11
@CoenWarmer CoenWarmer changed the title [Observability AI Assistant] Keep Chat Open On Navigation [Observability AI Assistant] Keep Chat Open On Navigation, use Resizable Flyout, allow Push and Overlay modes in Flyout Feb 17, 2024
dgieselaar
dgieselaar reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the change! In some cases there is some pretty aggressive unmounting/remounting, which makes the animation feel a little jarring. Maybe we can not run that on mount?

During reviewing I noticed the conversation list is no longer refreshed when creating a new conversation. I think it broke in 25898e6, will put up a fix.

x-pack/plugins/observability_ai_assistant/public/components/insight/insight.tsx Outdated Show resolved Hide resolved
...k/plugins/observability_ai_assistant/public/components/action_menu_item/action_menu_item.tsx Outdated Show resolved Hide resolved
...k/plugins/observability_ai_assistant/public/components/action_menu_item/action_menu_item.tsx Outdated Show resolved Hide resolved
...k/plugins/observability_ai_assistant/public/components/action_menu_item/action_menu_item.tsx Outdated Show resolved Hide resolved
x-pack/plugins/observability_ai_assistant/public/components/chat/chat_flyout.tsx Outdated Show resolved Hide resolved
@CoenWarmer
Copy link
Contributor Author

CoenWarmer commented Feb 21, 2024 •
edited
Loading

Going to put this on draft until elastic/eui#7536 is picked up.

Edit:
Decided to push on and remove the 'set width to 100%' button for now until elastic/eui#7536 is resolved.

@CoenWarmer CoenWarmer marked this pull request as draft February 21, 2024 11:10
@CoenWarmer CoenWarmer mentioned this pull request Mar 18, 2024
Merged
@CoenWarmer CoenWarmer force-pushed the feat/keep-flyout-useable branch from 3ae9892 to cb6a6f0 Compare March 18, 2024 20:43
@CoenWarmer CoenWarmer marked this pull request as ready for review March 18, 2024 20:46
@botelastic botelastic bot added the Team:obs-knowledge Observability Experience Knowledge team label Mar 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@CoenWarmer CoenWarmer force-pushed the feat/keep-flyout-useable branch from 88c148b to 9f35fd8 Compare March 18, 2024 21:09
@CoenWarmer CoenWarmer force-pushed the feat/keep-flyout-useable branch from 9f35fd8 to 8b99616 Compare March 18, 2024 21:10
dgieselaar
dgieselaar approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the small fixes as well, couple of qs but looks good other than that

...observability_solution/observability_ai_assistant_app/public/components/chat/chat_flyout.tsx Outdated Show resolved Hide resolved
...observability_solution/observability_ai_assistant_app/public/components/chat/chat_flyout.tsx Outdated Show resolved Hide resolved
...ability_solution/observability_ai_assistant_app/public/components/chat/chat_body.stories.tsx Show resolved Hide resolved
@CoenWarmer CoenWarmer enabled auto-merge (squash) March 19, 2024 09:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 85 86 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 15.7KB 16.0KB +303.0B
observabilityAIAssistantApp 140.5KB 140.4KB -185.0B
total +118.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistantApp 12.3KB 12.3KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit de5d2ce into elastic:main Mar 19, 2024
18 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-knowledge Observability Experience Knowledge team Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CoenWarmer @elasticmachine @apmmachine @kibana-ci @sorenlouv @dgieselaar @kibanamachine