Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-disc-timeline-int #157696

Closed

Conversation

michaelolo24
Copy link
Contributor

@michaelolo24 michaelolo24 commented May 15, 2023

WIP discover in timeline. The below video show's a simple integration of discover in timeline as a new discover tab. There are some bugs introduced such as the override of the extra actions in the topbar where the current security solution data view selector is. Not everything works smoothly, but it provides an initial look into how this might work

Screen.Recording.2023-05-15.at.3.21.04.PM.mov

@michaelolo24 michaelolo24 changed the title trial-discover-in-timeline test-disc-timeline-int May 15, 2023
@michaelolo24 michaelolo24 added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment labels May 15, 2023
@michaelolo24 michaelolo24 force-pushed the trial-discover-in-timeline branch from 05ec118 to 268a394 Compare May 15, 2023 16:39
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 15, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Pane renders with display block by default

Metrics [docs]

‼️ ERROR: metrics for 2361164 were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented May 22, 2023

I've checked this out, now I wonder, should changes be visible? If yes, how? Thx!

@michaelolo24
Copy link
Contributor Author

michaelolo24 commented May 22, 2023

I've checked this out, now I wonder, should changes be visible? If yes, how? Thx!

@kertal Rather than this PR, there is probably a better PR for you to look at, based on work by @semd 's here: semd#5 ....but for both, you can generate test data from the security_solution directory by running yarn test:generate, maybe yarn test:generate --gen 3. Then you can click on timeline like in the video in the summary for this PR and click on the discover tab :) . The other POC here also doesn't have the headerActions issue this pr has

@michaelolo24
Copy link
Contributor Author

Closing this in favor of this ticket: semd#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants