[RAM] Remove isSnoozeUntil and calculate on the fly for get/find #136148

XavierM · 2022-07-11T20:43:10Z

Summary

Refactor to avoid multiple call on the rule's SO and avoid some OCC's issue in the task runner
FIX: #135846 & #123584

…_occ

XavierM · 2022-07-12T00:38:12Z

@elasticmachine merge upstream

…_occ

…snooze_possible_occ

elasticmachine · 2022-07-12T20:44:14Z

Pinging @elastic/response-ops (Team:ResponseOps)

…_occ

jcger · 2022-07-26T11:00:14Z

...triggers_actions_ui/public/application/sections/rules_list/components/rule_status_filter.tsx

+      return (
+        <FormattedMessage
+          id="xpack.triggersActionsUI.sections.ruleDetails.ruleStateFilter.disabledOptionText"
+          defaultMessage="Rule is disabled"


nitpick save id and defaultMessage in a variable, set the value depending on each case and return the component once to avoid repeating code

I tried but I can NOT because https://github.com/elastic/kibana/issues/81862

jcger · 2022-07-26T11:06:42Z

LGTM! wasn't able to break it locally :P

JiaweiWu

LGTM!

…_occ

mdefazio

Let's take a look at the copy in another PR. I think it would also be good take another look at this filter and perhaps break it apart into two separate options.

lcawl · 2022-07-26T19:40:54Z

...triggers_actions_ui/public/application/sections/rules_list/components/rule_status_filter.tsx

+      return (
+        <FormattedMessage
+          id="xpack.triggersActionsUI.sections.ruleDetails.ruleStateFilter.enabledOptionText"
+          defaultMessage="Rule is enabled"


IMO this can be shortened:

Suggested change

defaultMessage="Rule is enabled"

defaultMessage="Enabled"

lcawl · 2022-07-26T19:42:38Z

...triggers_actions_ui/public/application/sections/rules_list/components/rule_status_filter.tsx

+      return (
+        <FormattedMessage
+          id="xpack.triggersActionsUI.sections.ruleDetails.ruleStateFilter.disabledOptionText"
+          defaultMessage="Rule is disabled"


Ditto re shorter is better, though we'll need to revisit this term in the future:

Suggested change

defaultMessage="Rule is disabled"

defaultMessage="Disabled"

lcawl · 2022-07-26T19:44:51Z

...triggers_actions_ui/public/application/sections/rules_list/components/rule_status_filter.tsx

+      return (
+        <FormattedMessage
+          id="xpack.triggersActionsUI.sections.ruleDetails.ruleStateFilter.snoozedOptionText"
+          defaultMessage="Rule has snoozed"


Though there seems to be complexity around whether the snooze is active or not, perhaps it's sufficient to just say there's a snooze schedule. If it's also supposed to cover snoozes that happened in the past (and are not recurring), perhaps "Snooze configured"?:

Suggested change

defaultMessage="Rule has snoozed"

defaultMessage="Snooze scheduled"

it is also possible to just have a relative snooze like I only want to snooze this rule for two hours.

To me a relative snooze is still something you schedule, so IMO that text would work for both. We can pursue further options in a subsequent PR.

kibana-ci · 2022-07-26T20:23:38Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	958.8KB	959.4KB	+559.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	90.6KB	90.6KB	-17.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`alert`	75	74	-1

History

💔 Build #60932 failed f094c3c
💔 Build #60918 failed 3173f7a
💔 Build #60892 failed 17fdf3b
💔 Build #60876 failed 9ae9b36
💔 Build #60735 failed b1c3fb0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

refactor to avoid multiple call to the SO and avoid some kind of occ

2995cae

XavierM added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.0 labels Jul 11, 2022

XavierM added 2 commits July 11, 2022 16:44

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

3c05a1e

…_occ

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

750b832

…_occ

kibanamachine and others added 6 commits July 11, 2022 20:38

Merge branch 'main' into snooze_possible_occ

435c120

simplify logic

7f945e0

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

0cac9b6

…_occ

formatting + test

f3c8b02

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

750b5e6

…_occ

Merge branch 'snooze_possible_occ' of github.com:XavierM/kibana into …

34a0748

…snooze_possible_occ

XavierM marked this pull request as ready for review July 12, 2022 20:44

XavierM requested a review from a team as a code owner July 12, 2022 20:44

XavierM requested review from Zacqary and mikecote July 12, 2022 20:44

XavierM marked this pull request as draft July 13, 2022 00:32

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

46176d5

…_occ

Zacqary mentioned this pull request Jul 14, 2022

[RAM] Make the Cancel Snooze button skip the current recurrence #132860

Closed

XavierM changed the title ~~[RAM] Refactor to avoid multiple call on the rule's SO and avoid some kind of OCC in the task runner~~ [RAM] Remove isSnoozeUntil and calculate on the fly for get/find Jul 18, 2022

XavierM added 4 commits July 19, 2022 04:42

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

bed6f6b

…_occ

Remove isSnoozeUntil has a saved object attributes

6a1c464

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

d360305

…_occ

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

ad177cb

…_occ

XavierM mentioned this pull request Jul 26, 2022

Change rule filter button text #136709

Closed

XavierM added 2 commits July 26, 2022 05:58

update rule list to use rule has snooze as a filter

c057685

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

0d4d57b

…_occ

XavierM requested review from jcger and JiaweiWu and removed request for Zacqary July 26, 2022 10:01

fix check type

b1c3fb0

rudolf approved these changes Jul 26, 2022

View reviewed changes

jcger reviewed Jul 26, 2022

View reviewed changes

jcger approved these changes Jul 26, 2022

View reviewed changes

mdefazio self-requested a review July 26, 2022 13:33

JiaweiWu approved these changes Jul 26, 2022

View reviewed changes

XavierM added 2 commits July 26, 2022 11:46

update functional test + review I

7d6af70

Merge branch 'main' of github.com:elastic/kibana into snooze_possible…

9ae9b36

…_occ

XavierM enabled auto-merge (squash) July 26, 2022 15:48

XavierM and others added 4 commits July 26, 2022 12:05

https://github.com/elastic/kibana/issues/81862

f4535ef

Fix rules list e2e tests

17fdf3b

Update snapshots

3173f7a

Fix e2e tests

f094c3c

mdefazio approved these changes Jul 26, 2022

View reviewed changes

Fix e2e tests

8b41951

lcawl reviewed Jul 26, 2022

View reviewed changes

XavierM merged commit cc31f24 into elastic:main Jul 26, 2022

kibanamachine added the backport:skip This commit does not require backporting label Jul 26, 2022

lcawl added the ui-copy Review of UI copy with docs team is recommended label Jul 26, 2022

gmmorris added the Feature:Alerting/RulesManagement Issues related to the Rules Management UX label Jul 29, 2022

benakansara mentioned this pull request Aug 11, 2022

[Actionable observability] Update View filter title in Rules' list page #136301

Closed

emma-raffenne mentioned this pull request Aug 11, 2022

Bulk actions for mute/disable/delete rules #123584

Closed

ymao1 mentioned this pull request Aug 25, 2022

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] Remove isSnoozeUntil and calculate on the fly for get/find #136148

[RAM] Remove isSnoozeUntil and calculate on the fly for get/find #136148

XavierM commented Jul 11, 2022 •

edited

Loading

XavierM commented Jul 12, 2022

elasticmachine commented Jul 12, 2022

jcger Jul 26, 2022

XavierM Jul 26, 2022

jcger commented Jul 26, 2022

JiaweiWu left a comment

mdefazio left a comment

lcawl Jul 26, 2022

lcawl Jul 26, 2022 •

edited

Loading

lcawl Jul 26, 2022 •

edited

Loading

XavierM Jul 26, 2022

lcawl Jul 26, 2022

kibana-ci commented Jul 26, 2022

	defaultMessage="Rule has snoozed"
	defaultMessage="Snooze scheduled"

[RAM] Remove isSnoozeUntil and calculate on the fly for get/find #136148

[RAM] Remove isSnoozeUntil and calculate on the fly for get/find #136148

Conversation

XavierM commented Jul 11, 2022 • edited Loading

Summary

XavierM commented Jul 12, 2022

elasticmachine commented Jul 12, 2022

jcger Jul 26, 2022

Choose a reason for hiding this comment

XavierM Jul 26, 2022

Choose a reason for hiding this comment

jcger commented Jul 26, 2022

JiaweiWu left a comment

Choose a reason for hiding this comment

mdefazio left a comment

Choose a reason for hiding this comment

lcawl Jul 26, 2022

Choose a reason for hiding this comment

lcawl Jul 26, 2022 • edited Loading

Choose a reason for hiding this comment

lcawl Jul 26, 2022 • edited Loading

Choose a reason for hiding this comment

XavierM Jul 26, 2022

Choose a reason for hiding this comment

lcawl Jul 26, 2022

Choose a reason for hiding this comment

kibana-ci commented Jul 26, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

Saved Objects .kibana field count

History

XavierM commented Jul 11, 2022 •

edited

Loading

lcawl Jul 26, 2022 •

edited

Loading

lcawl Jul 26, 2022 •

edited

Loading