Remove waitFor in flyout tests

elastic · Jan 15, 2025 · fb3027e · fb3027e
1 parent fd0a82b
commit fb3027e
Showing 1 changed file with 8 additions and 16 deletions.
diff --git a/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx b/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx
@@ -8,7 +8,7 @@
  */
 
 import React from 'react';
-import { fireEvent, render, screen, waitFor } from '@testing-library/react';
+import { fireEvent, render, screen } from '@testing-library/react';
 import { RuleFlyout } from './rule_flyout';
 import {
   RULE_FORM_PAGE_RULE_DEFINITION_TITLE_SHORT,
@@ -110,30 +110,22 @@ describe('ruleFlyout', () => {
     render(<RuleFlyout onCancel={onCancel} onSave={onSave} />);
 
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton'));
-    await waitFor(() =>
-      expect(screen.getByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument()
-    );
+    expect(await screen.findByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument();
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton'));
-    await waitFor(() =>
-      expect(screen.getByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument()
-    );
+    expect(await screen.findByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument();
+
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterPreviousStepButton'));
-    await waitFor(() =>
-      expect(screen.getByTestId('ruleFlyoutFooterNextStepButton')).toBeInTheDocument()
-    );
+    expect(await screen.findByTestId('ruleFlyoutFooterNextStepButton')).toBeInTheDocument();
   });
 
   test('should call onSave when save button is pressed', async () => {
     render(<RuleFlyout onCancel={onCancel} onSave={onSave} />);
 
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton'));
-    await waitFor(() =>
-      expect(screen.getByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument()
-    );
+    expect(await screen.findByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument();
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton'));
-    await waitFor(() =>
-      expect(screen.getByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument()
-    );
+    expect(await screen.findByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument();
+
     fireEvent.click(screen.getByTestId('ruleFlyoutFooterSaveButton'));
 
     expect(onSave).toHaveBeenCalledWith({