[Discover] Unskip Edit field flyout tests

elastic · Feb 3, 2025 · 5de1c9d · 5de1c9d
1 parent 59a15be
commit 5de1c9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/test/functional/apps/management/data_views/_handle_version_conflict.ts b/test/functional/apps/management/data_views/_handle_version_conflict.ts
@@ -21,7 +21,6 @@ import { ANALYTICS_SAVED_OBJECT_INDEX } from '@kbn/core-saved-objects-server';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const testSubjects = getService('testSubjects');
   const kibanaServer = getService('kibanaServer');
   const browser = getService('browser');
   const es = getService('es');
@@ -31,8 +30,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const log = getService('log');
   const toasts = getService('toasts');
 
-  // Failing: See https://github.com/elastic/kibana/issues/193102
-  describe.skip('FOO index version conflict', function describeIndexTests() {
+  describe('FOO index version conflict', function describeIndexTests() {
     before(async function () {
       await browser.setWindowSize(1200, 800);
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
@@ -77,11 +75,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       log.debug('Starting openControlsByName (' + fieldName + ')');
       await PageObjects.settings.openControlsByName(fieldName);
       log.debug('controls are open');
-      await (
-        await (
-          await testSubjects.find('formatRow')
-        ).findAllByCssSelector('[data-test-subj="toggle"]')
-      )[0].click();
+      await PageObjects.settings.toggleRow('formatRow');
       await PageObjects.settings.setFieldFormat('url');
       const response = await es.update(
         {

diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -407,6 +407,9 @@ export class SettingsPageObject extends FtrService {
       `table.euiTable tbody tr.euiTableRow:nth-child(${tableFields.indexOf(name) + 1})
         td:nth-last-child(2) button`
     );
+    await this.retry.waitFor('flyout to open', async () => {
+      return await this.testSubjects.exists('flyoutTitle');
+    });
   }
 
   async increasePopularity() {