-
Notifications
You must be signed in to change notification settings - Fork 540
[Imperva] update documentation #17371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haetamoudi
wants to merge
2
commits into
elastic:main
Choose a base branch
from
haetamoudi:update-imperva-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+682
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Contributor
Vale Linting ResultsSummary: 17 warnings, 6 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/imperva/_dev/build/docs/README.md | 18 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/_dev/build/docs/README.md | 65 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/README.md | 18 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/README.md | 65 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/README.md | 207 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/README.md | 220 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/README.md | 242 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/imperva/docs/README.md | 262 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 21 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 69 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 73 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 86 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 90 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 102 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 106 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/imperva/docs/knowledge_base/service_info.md | 111 | Elastic.EndPuntuaction | Don't end headings with punctuation. |
| packages/imperva/docs/knowledge_base/service_info.md | 154 | Elastic.EndPuntuaction | Don't end headings with punctuation. |
💡 Suggestions (6)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/imperva/_dev/build/docs/README.md | 20 | Elastic.Versions | Use 'or later' instead of 'or higher' when referring to versions. |
| packages/imperva/_dev/build/docs/README.md | 37 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
| packages/imperva/_dev/build/docs/README.md | 55 | Elastic.Versions | Use 'or later' instead of 'or higher' when referring to versions. |
| packages/imperva/docs/README.md | 20 | Elastic.Versions | Use 'or later' instead of 'or higher' when referring to versions. |
| packages/imperva/docs/README.md | 37 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
| packages/imperva/docs/README.md | 55 | Elastic.Versions | Use 'or later' instead of 'or higher' when referring to versions. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation. Applied to PRs that modify *.md files.
Integration:imperva
Imperva
Team:Integration-Experience
Security Integrations Integration Experience [elastic/integration-experience]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
[imperva] Documentation Update
generated new knowledge base file
generated new documentation
Please explain:
This text will be pasted into the squash dialog when the change is committed and will be
a long term historical record of the change to help future contributors understand the
change, please help them by making it clear and comprehensive, they may be you.
If the commit title is adequate to describe both of these things, The text here may be omitted
or replaced with "See title". The title of the PR will be used as the commit message title when
the merge is made and the "See title" marker will be removed if present.
The text here and the PR title will be subject to the PR review process.
-->
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots