-
Notifications
You must be signed in to change notification settings - Fork 525
[amazon_bedrock_agentcore] add memory_application_logs data stream
#16588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
| required: false | ||
| show_user: false | ||
| description: Include log groups from linked accounts when using `log_group_name_prefix` to derive the monitoring log groups. | ||
| - name: region_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it makes sense to put region_name right after log_group_name_prefix since region_name i required if log_group_name_prefix is provided. I think it would make it better UX (just an IMHO)
| default: 1 | ||
| required: false | ||
| show_user: false | ||
| description: The number of workers assigned to read from log groups. Each worker will read log events from one of the log groups matching `log_group_name_prefix`. For example, if `log_group_name_prefix` matches five log groups, then `number_of_workers` should be set to `5`. The default value is `1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that if we 1 is set in this field but log_group_name_prefix matches five log groups we would collect data only for one of them?
| required: false | ||
| show_user: false | ||
| default: 5 | ||
| description: The maximum number of times a SQS message should be received (retried) before deleting it. This feature prevents poison-pill messages (messages that can be received but can't be processed) from consuming resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to mention here that it might be beneficial to use dead-letter queues instead? That way it prevents poison-pill messages and keeps failing messages for troubleshooting purposes (but might increase AWS cost).
|
/test |
💚 Build Succeeded
History
cc @gpop63 |
Overview
This PR adds the
memory_application_logsdata stream.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots